Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Promote kube_statefulset_ordinals_start from ALPHA -> STABLE #2415

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Jun 7, 2024

What this PR does / why we need it:
Promote kube_statefulset_ordinals_start metrics from ALPHA -> STABLE

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change the cardinality of KSM

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2024
@pwschuurman pwschuurman changed the title Promote kube_statefulset_ordinals_start from ALPHA -> BETA feat: Promote kube_statefulset_ordinals_start from ALPHA -> BETA Jun 7, 2024
@mrueg
Copy link
Member

mrueg commented Jun 13, 2024

I don't have any strong opinions here, I believe we haven't used beta before and went directly to stable.
Any thoughts on this from people that care more about metrics stability? @dgrisonnet @rexagod @CatherineF-dev @logicalhan

@dgrisonnet
Copy link
Member

/triage accepted

I think this should wait for the next major since the current stability model only used Experimental and Stable.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 13, 2024
@pwschuurman
Copy link
Contributor Author

I think this should wait for the next major since the current stability model only used Experimental and Stable.

Thanks. @dgrisonnet Just to clarify, would you be OK with this PR being updated to use Stable instead of Beta? Or are you suggesting that this PR (promoting kube_statefulset_ordinals_start) should wait until the next major release?

@pwschuurman
Copy link
Contributor Author

Hi @dgrisonnet @mrueg, any guidance on how to proceed with this PR? Sounds like the options are:

  1. Merge as-is with Stable
  2. Wait for next major release and promote from Alpha -> Beta

@dgrisonnet
Copy link
Member

I think we should wait for either the next major to update to the correct stability level at the time or wait for the feature to become stable before making the metric stable here.

My reasoning is that at the moment there is only Experimental (Alpha) and Stable in kube-state-metrics and there is always the possibility that a Beta feature in k/k never reaches Stable and gets deprecated/removed.

@pwschuurman
Copy link
Contributor Author

Great, thanks @dgrisonnet. kubernetes/enhancements#3335 is on track to be Stable in 1.31. I'll follow-up after 1.31 is released.

@atiratree
Copy link
Member

@pwschuurman I suppose, this can proceed for 1.32 now, right?

@dgrisonnet
Copy link
Member

@pwschuurman can you please update the PR to mark the metric as Stable?

@mrueg
Copy link
Member

mrueg commented Nov 6, 2024

@pwschuurman any interest in continuing on this one before we release v2.14?

@pwschuurman
Copy link
Contributor Author

@mrueg Yes, interested. Will update this today.

@pwschuurman pwschuurman force-pushed the kep-3335-stable-metrics branch from 20b036c to 7a757b5 Compare November 8, 2024 00:55
@pwschuurman pwschuurman changed the title feat: Promote kube_statefulset_ordinals_start from ALPHA -> BETA feat: Promote kube_statefulset_ordinals_start from ALPHA -> STABLE Nov 8, 2024
@pwschuurman
Copy link
Contributor Author

@mrueg @dgrisonnet Updated PR and description

@pwschuurman pwschuurman force-pushed the kep-3335-stable-metrics branch from 7a757b5 to 098e785 Compare November 25, 2024 18:56
@mrueg
Copy link
Member

mrueg commented Nov 25, 2024

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9652811 into kubernetes:main Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants