-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Promote kube_statefulset_ordinals_start from ALPHA -> STABLE #2415
feat: Promote kube_statefulset_ordinals_start from ALPHA -> STABLE #2415
Conversation
I don't have any strong opinions here, I believe we haven't used beta before and went directly to stable. |
/triage accepted I think this should wait for the next major since the current stability model only used |
Thanks. @dgrisonnet Just to clarify, would you be OK with this PR being updated to use Stable instead of Beta? Or are you suggesting that this PR (promoting |
Hi @dgrisonnet @mrueg, any guidance on how to proceed with this PR? Sounds like the options are:
|
I think we should wait for either the next major to update to the correct stability level at the time or wait for the feature to become stable before making the metric stable here. My reasoning is that at the moment there is only Experimental (Alpha) and Stable in kube-state-metrics and there is always the possibility that a Beta feature in k/k never reaches Stable and gets deprecated/removed. |
Great, thanks @dgrisonnet. kubernetes/enhancements#3335 is on track to be Stable in 1.31. I'll follow-up after 1.31 is released. |
@pwschuurman I suppose, this can proceed for 1.32 now, right? |
@pwschuurman can you please update the PR to mark the metric as Stable? |
@pwschuurman any interest in continuing on this one before we release v2.14? |
@mrueg Yes, interested. Will update this today. |
20b036c
to
7a757b5
Compare
@mrueg @dgrisonnet Updated PR and description |
7a757b5
to
098e785
Compare
/lgtm Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Promote
kube_statefulset_ordinals_start
metrics from ALPHA -> STABLEHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change the cardinality of KSM