Cut 1.0.1 #242
Merged
Cut 1.0.1 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Is this a cherry-pick from master? If yes could you please link it here? If not could you please first fix the bug on master branch? |
|
@piosz yes this is a fix that is already in master. How do you want me to link to it, issue, PR or commit (or all)? |
|
sgtm |
|
@piosz do you want me to link in the changelog or just in the PR description? |
|
Just in PR description. |
|
@piosz updated the PR description to include the issue where it was reported and the fixing PR. |
|
@brancz thanks! |
|
Shall we merge this since all comments addressed. |
|
/assign @piosz |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
merge based on comment above. ping @brancz @piosz @loburm for building and pushing images. |
while1malloc0
pushed a commit
to while1malloc0/kube-state-metrics
that referenced
this pull request
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting this as it's going to take a bit of time until we release
v1.1.0, as there are few more things to figure out for that. But to ensure people have an official release and don't get nil panics I wanted to just backport this.The fix that is being backported is #240, which was originally reported in #239.
@fabxc @andyxning @matthiasr
I'll coordinate publishing the images with @loburm / @piosz .
/cc @smarterclayton
This change is