-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Add automatic detection of memory limits #2447
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @SuperQ! |
We added this to Prometheus (prometheus/prometheus#13395) and it helps a lot in our production environment. |
Thanks, looks interesting! |
Ah can you run |
Updated docs. |
Looks like the lint is still complaining about a the wrong format for the auto gomemlimit ratio |
Add automatic detection of container and system memory limits to control the Go `GOMEMLIMIT` garbage collector feature. This helps reduced OOMs by triggering GC when the process approaches system limits. Signed-off-by: SuperQ <superq@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, SuperQ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qq: Will cpu increase a lot if GC is triggered frequently? |
What this PR does / why we need it:
Add automatic detection of container and system memory limits to control the Go
GOMEMLIMIT
garbage collector feature. This helps reduced OOMs by triggering GC when the process approaches system limits.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
N/A
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #