chore: Bump to kubernetes 1.31.0 #2492
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
@CatherineF-dev can you take another look? Thanks! |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
I think it might be better to follow the same deprecation plan as upstream. Removing it directly might be harmless here, but at least following the same plan as Kubernetes would set a precedent for what we should do in the future when such thing happen. We could make a deprecation notice in the next release changelog and then fully remove the label once the feature is removed? |
| @@ -3,7 +3,7 @@ | |||
| | Metric name | Metric type | Description | Unit (where applicable) | Labels/tags | Status | | |||
| | ---------------------------- | ----------- | ------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------ | | |||
| | kube_node_annotations | Gauge | Kubernetes annotations converted to Prometheus labels controlled via [--metric-annotations-allowlist](../../developer/cli-arguments.md) | | `node`=<node-address> <br> `annotation_NODE_ANNOTATION`=<NODE_ANNOTATION> | EXPERIMENTAL | | |||
| | kube_node_info | Gauge | Information about a cluster node | | `node`=<node-address> <br> `kernel_version`=<kernel-version> <br> `os_image`=<os-image-name> <br> `container_runtime_version`=<container-runtime-and-version-combination> <br> `kubelet_version`=<kubelet-version> <br> `kubeproxy_version`=<kubeproxy-version> <br> `pod_cidr`=<pod-cidr> <br> `provider_id`=<provider-id> <br> `system_uuid`=<system-uuid> <br> `internal_ip`=<internal-ip> | STABLE | | |||
There was a problem hiding this comment.
I would rather preserve API stability but just enter a constant "disabled" value for the existing label.
|
I made the requested changes, please have another look. |
k8s-ci-robot
removed
the
needs-rebase
|
/hold cancel @CatherineF-dev @rexagod @dgrisonnet friendly ping on this one :) |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
needs-rebase
Breaking change for node metrics, as kube-proxy field is deprecated and contains invalid information. See also https://kubernetes.io/blog/2024/07/19/kubernetes-1-31-upcoming-changes/#deprecation-of-status-nodeinfo-kubeproxyversion-field-for-nodes-kep-4004-https-github-com-kubernetes-enhancements-issues-4004
|
/lgtm Holding for others, feel free to unhold. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Just a friendly reminder about the missing reviews so we can get this merged. Thanks! |
|
/hold cancel I'd say this has been waiting long enough. If people have additional concerns, they can follow up with their own PR. |
k8s-ci-robot
removed
the
do-not-merge/hold
What this PR does / why we need it:
Uses kubernetes 1.31 client libs
This change breaks a stable metric - I believe this is justified as the metric label never gave a correct result.
https://kubernetes.io/blog/2024/07/19/kubernetes-1-31-upcoming-changes/#deprecation-of-status-nodeinfo-kubeproxyversion-field-for-nodes-kep-4004-https-github-com-kubernetes-enhancements-issues-4004
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #