fix(custom resource state metrics): correctly convert status condition Unknown to a valid value

[Haleygo]

What this PR does / why we need it:

According to https://github.com/kubernetes/kube-state-metrics/blob/main/docs/metrics/extend/customresourcestate-metrics.md#gauge

This will work for kubernetes controller CRs which expose status conditions according to the kubernetes api (https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#Condition):

ConditionUnknown = "Unknown" should be converted corrctly to a valid value, and more like 0.0 instead of 1.0.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Does not change cardinality.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2439

[mrueg]

Thanks for the contribution!
I don't think 0.0 is the right way to treat an unknown value as it could be misleading. I think a possible option might be -1.0 for any unknown value. (but I would love to see others chime in on that as well).

@rexagod @dgrisonnet @CatherineF-dev wdyt?

[CatherineF-dev]

Agree on -1 to distinguish this unknown with others.

[richabanker]

/triage accepted
/assign @mrueg

[Haleygo]

@mrueg Thanks for reviewing! I have updated the value and doc, please check.

[itaiatu]

/lgtm

[k8s-ci-robot]

@itaiatu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[itaiatu]

We also encountered this issue and this small fix will solve it.

[CatherineF-dev]

/lgtm

[CatherineF-dev]

Hi @mrueg, could you help add this into v2.14.0 milestone? https://github.com/kubernetes/kube-state-metrics/milestone/7

Thx

[mrueg]

@dgrisonnet made me aware of

kube-state-metrics/internal/store/node_test.go

Lines 186 to 188 in 0738de0

	kube_node_status_condition{condition="CustomizedType",node="127.0.0.1",status="false"} 0
	kube_node_status_condition{condition="CustomizedType",node="127.0.0.1",status="true"} 1
	kube_node_status_condition{condition="CustomizedType",node="127.0.0.1",status="unknown"} 0

in which we expose the status Unknown as 0 as well. Could you change it back to 0 instead of -1 for consistency?
Thanks and apologies for the extra work!

[mrueg]

Made the changes myself real quick to get it into the v2.14.0 release

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, Haleygo, itaiatu, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment