-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kube_pod_tolerations): deduplicate tolerations before creating metric #2559
base: main
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RiRa12621 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @RiRa12621! |
/assign @dgrisonnet |
The solution looks good to me. |
+1 |
Sure, I'll get that changed tomorrow |
@RiRa12621 are you still working on that PR? |
Planning to, was just overly busy at day job |
What this PR does / why we need it:
duplicate metrics currently create warnings in the logs of prometheus. Tolerations can be duplicated and kube-api doesn't want to change that behavior, hence we have to deduplicate here
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
does not change cardinality
Which issue(s) this PR fixes
Fixes #2390