Revert "add componentstatus metrics" #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
zouyee
reviewed
Dec 15, 2017
main.go
Outdated
| @@ -66,7 +65,6 @@ var ( | |||
| "horizontalpodautoscalers": struct{}{}, | |||
| } | |||
| availableCollectors = map[string]func(registry prometheus.Registerer, kubeClient clientset.Interface, namespace string){ | |||
| "componentstatuses": collectors.RegisterComponentStatusCollector, | |||
There was a problem hiding this comment.
componentstatuses options need to be removed from --collectors
There was a problem hiding this comment.
@zouyee The default value for --collectors is of defaultCollectors keys which has componentstatuses removed.
|
I don't think we have to revert, let's just fix the problem I described in the comment on the original PR. |
andyxning
force-pushed
the
revert_add_componentstatus
branch
from
1f2df63
to
c797923
Compare
|
You were right, sorry, I didn't quite understand at first. |
while1malloc0
pushed a commit
to while1malloc0/kube-state-metrics
that referenced
this pull request
Jul 2, 2018
…status Revert "add componentstatus metrics"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5452f06.
As for now
componentstatusesdoes not supportwatchmethod, we can not watch on it. This should fix 219 comment.ping @zouyee
/cc @brancz
This change is