add kube_replicatset_owner metric #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
andyxning
force-pushed
the
add_replicaset_owner
branch
from
ada5162
to
2d69aeb
Compare
mxinden
reviewed
Aug 20, 2018
pkg/collectors/replicaset.go
Outdated
| } | ||
|
|
||
| // Collect implements the prometheus.Collector interface. | ||
| func (dc *replicasetCollector) Collect(ch chan<- prometheus.Metric) { | ||
| rss, err := dc.store.List() | ||
| func (rs *replicasetCollector) Collect(ch chan<- prometheus.Metric) { |
There was a problem hiding this comment.
Small nit, looking at the other controllers this should be called rc or rsc, right?
There was a problem hiding this comment.
Good catch. rsc should be fine.
andyxning
force-pushed
the
add_replicaset_owner
branch
from
2d69aeb
to
991e511
Compare
|
This lgtm, but putting a hold on this until we lift the feature freeze. /hold |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, brancz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zouyee
approved these changes
Aug 21, 2018
|
/hold cacel |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
kube_replicaset_ownermetric.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #510