Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replicaset label metrics #638

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Add replicaset label metrics #638

merged 3 commits into from
Jan 23, 2019

Conversation

kminehart
Copy link
Contributor

@kminehart kminehart commented Jan 22, 2019

What this PR does / why we need it: This PR adds the kube_replicaset_labels metric. In some edge case scenarios this can be useful.

In our environment, we heavily use labels for tenancy. Developers want to be able to see how often they "deploy" an update; this can normally be done using kube_deployment_created, unless the deployment is updated. When the deployment is updated, a new replicaset is created, so we use kube_replicaset_created, but we can not determine what team owns the replicaset without being able to access its labels

I'm having minikube issues so I'm unable to run the e2e tests locally 😅

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2019
@kminehart
Copy link
Contributor Author

I'm unsure why the travis build failed, it does not seem relevant to the changes I've made.

/assign @mxinden

Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kminehart.

This looks good to me. Adding this single metric should be fine, given that we already have the replicaset dimension in our cardinality set.

Still giving @brancz @andyxning @zouyee a chance to reply before merging.

The test failure was a flake.

@brancz
Copy link
Member

brancz commented Jan 23, 2019

I'm having minikube issues so I'm unable to run the e2e tests locally 😅

Please let us know how we can improve docs to make this easier for the next contributor :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, kminehart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 491d94d into kubernetes:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants