Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ingress labels #640

Merged
merged 3 commits into from
Feb 6, 2019
Merged

add ingress labels #640

merged 3 commits into from
Feb 6, 2019

Conversation

r0fls
Copy link
Contributor

@r0fls r0fls commented Jan 24, 2019

What this PR does / why we need it:
Add an Ingress collector. There is currently no ingress collector.

Which issue(s) this PR fixes:
Fixes #573

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2019
mxinden
mxinden reviewed Jan 25, 2019
View reviewed changes
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

pkg/collectors/builder.go Outdated Show resolved Hide resolved
pkg/collectors/ingress.go Outdated Show resolved Hide resolved
pkg/collectors/ingress.go Outdated Show resolved Hide resolved
pkg/collectors/ingress_test.go Outdated Show resolved Hide resolved
pkg/collectors/ingress_test.go Outdated Show resolved Hide resolved
pkg/collectors/ingress_test.go Outdated Show resolved Hide resolved
brancz
brancz reviewed Jan 28, 2019
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor nit, otherwise lgtm

pkg/collectors/ingress_test.go Outdated Show resolved Hide resolved
@r0fls
Copy link
Contributor Author

r0fls commented Feb 5, 2019

Anything else I can do here to help get this merged? I've tested using it on our clusters

@brancz
Copy link
Member

brancz commented Feb 5, 2019

this needs a rebase

@r0fls
Copy link
Contributor Author

r0fls commented Feb 5, 2019

rebased ✔️

@r0fls
Copy link
Contributor Author

r0fls commented Feb 6, 2019

@brancz rebased and added an ingress manifest for the e2e tests

@mxinden
Copy link
Contributor

mxinden commented Feb 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mxinden, r0fls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 587407f into kubernetes:master Feb 6, 2019
@gaopeiliang
Copy link

gaopeiliang commented Mar 29, 2019 •
edited
Loading

Ingress info metrics not find in v1.5 , is it release? .. I want to find ingress ==>> service info with metrics ....

dghubble added a commit to poseidon/typhoon that referenced this pull request Apr 10, 2019
@dghubble
Update kube-state-metrics from v1.5.0 to v1.6.0-rc.0
de70494 
* Adds a metrics collector for Ingress resources and other
improvements
* kubernetes/kube-state-metrics#640
@dghubble dghubble mentioned this pull request Apr 10, 2019
Merged
dghubble added a commit to poseidon/typhoon that referenced this pull request Apr 10, 2019
@dghubble
Update kube-state-metrics from v1.5.0 to v1.6.0-rc.0
6e5d66c 
* Adds a metrics collector for Ingress resources and other
improvements
* kubernetes/kube-state-metrics#640
* https://github.com/kubernetes/kube-state-metrics/releases/tag/v1.6.0-rc.0