Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into release-1.6 for v1.6.0-rc.0 #716

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Conversation

mxinden
Copy link
Contributor

@mxinden mxinden commented Apr 8, 2019

Once this is merged I will:

  • Tag the commit and push it.

  • Create the release in Github.

Anything missing @brancz @andyxning?

(Instead of this PR, we could have deleted release-1.6 and recreate it based on current master, sparing the additional merge commit. Problem is, that I can't delete the branch given that it is protected.)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2019
@brancz
Copy link
Member

brancz commented Apr 8, 2019

/lgtm

cc @piosz @loburm @kawych @serathius please stand by to push the image to gcr.io

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, mxinden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d7b8a74 into release-1.6 Apr 8, 2019
@mxinden
Copy link
Contributor Author

mxinden commented Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants