Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use xenial dist in travis ci #722

Merged

Conversation

andyxning
Copy link
Member

What this PR does / why we need it:
This PR updates travis ci distribution to 16.04.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
@andyxning andyxning force-pushed the use_xenial_dist_in_travis_ci branch from 7d43da0 to 166989b Compare April 16, 2019 09:08
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@andyxning andyxning force-pushed the use_xenial_dist_in_travis_ci branch from 166989b to 5c4b6f4 Compare April 16, 2019 09:32
@andyxning
Copy link
Member Author

@brancz
Copy link
Member

brancz commented Apr 16, 2019

neat 👍

/lgtm

as a side note we might want to start looking into kind, I've seen great speed-ups in other setups, but also if this works for us I don't see a huge reason to change right now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, brancz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ef24c76 into kubernetes:master Apr 16, 2019
@andyxning andyxning deleted the use_xenial_dist_in_travis_ci branch April 17, 2019 03:47
@andyxning
Copy link
Member Author

as a side note we might want to start looking into kind, I've seen great speed-ups in other setups, but also if this works for us I don't see a huge reason to change right now

It seems that kind is not so general as minikube. Since minikube v1.0.0 has been released and it should be stable enough, pinning on minikube should be ok for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants