Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: cut v1.7.0-rc.0 #814

Merged
merged 1 commit into from
Jul 10, 2019
Merged

*: cut v1.7.0-rc.0 #814

merged 1 commit into from
Jul 10, 2019

Conversation

brancz
Copy link
Member

@brancz brancz commented Jul 10, 2019

We've collected quite a few things and I don't think there are any features outstanding that we want to get into 1.7, so here it goes.

@mxinden @andyxning @tariq1890 @lilic

cc @serathius @piosz @DirectXMan12 please stand by to publish the gcr.io image :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
lilic
lilic approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise 🎉

CHANGELOG.md Outdated
* [FEATURE] Add Metrics About StorageClass. #777
* [FEATURE] Allow black/white- listing of metrics by regex. #773
* [FEATURE] Add metrics for VerticalPodAutoscaler objects (experimental and disabled by default). #791
* [FEATURE] Add (experimental) kube_*_annotations metrics. #770
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: To stay consistent with the formatting style of the CHANGELOG:

Suggested change
* [FEATURE] Add (experimental) kube_*_annotations metrics. #770
* [FEATURE] Add (experimental) `kube_*_annotations metrics`. #770

CHANGELOG.md Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor

tariq1890 commented Jul 10, 2019 •
edited

Let's update the version support matrix in the Readme. We need to add a row for v1.7.0. This needs to be recorded in Changelog as well.

@andyxning
Copy link
Member

How about the image versions?

@brancz
Copy link
Member Author

brancz commented Jul 10, 2019

Let's update the version support matrix in the Readme. We need to add a row for v1.7.0. This needs to be recorded in Changelog as well.

Will do!

How about the image versions?

We historically never updated the manifests with pre-releases.

@brancz
Copy link
Member Author

brancz commented Jul 10, 2019

@tariq1890 done. Please take a look 🙂 .

@tariq1890
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 48a9424 into kubernetes:master Jul 10, 2019
@brancz brancz deleted the cut-v1.7.0-rc.0 branch July 10, 2019 17:14
@brancz
Copy link
Member Author

brancz commented Jul 10, 2019

Container image is published at quay.io/coreos/kube-state-metrics:v1.7.0-rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@mxinden mxinden Awaiting requested review from mxinden

Assignees

@tariq1890 tariq1890

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brancz @tariq1890 @andyxning @k8s-ci-robot @lilic