RELEASE.md: Mention period of time for rc #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
tariq1890
reviewed
Jul 15, 2019
RELEASE.md
Outdated
|
|
||
| ## Stable release | ||
|
|
||
| First a release candidate should be cut, e.g. `v.1.2.3-rc.0` should be cut and if after a period of 7 days no bugs or issues were reported with the release candidate, a stable release can be cut. |
There was a problem hiding this comment.
To make this more illustrative, let's add the v1.2.3 as an example for a stable release.
|
Thanks for this @lilic :). I've provided my comments. |
|
@tariq1890 Done, PTAL thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiliC, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As mentioned in the #770 (comment) we want to clarify this in the RELEASE.md.
Question: Should we add a step to always explicitly mention this in the release candidate notes e.g. here -> https://github.com/kubernetes/kube-state-metrics/releases/tag/v1.7.0-rc.1
cc @tariq1890 @brancz