-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE.md: Mention period of time for rc #823
Conversation
RELEASE.md
Outdated
|
||
## Stable release | ||
|
||
First a release candidate should be cut, e.g. `v.1.2.3-rc.0` should be cut and if after a period of 7 days no bugs or issues were reported with the release candidate, a stable release can be cut. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this more illustrative, let's add the v1.2.3
as an example for a stable release.
Thanks for this @lilic :). I've provided my comments. |
@tariq1890 Done, PTAL thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiliC, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What this PR does / why we need it:
As mentioned in the #770 (comment) we want to clarify this in the RELEASE.md.
Question: Should we add a step to always explicitly mention this in the release candidate notes e.g. here -> https://github.com/kubernetes/kube-state-metrics/releases/tag/v1.7.0-rc.1
cc @tariq1890 @brancz