Revert "add kube_*_annotations metrics for all objects" #859
Conversation
This reverts commit 5ae00bb.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
internal/store/namespace.go
Outdated
| @@ -32,6 +32,10 @@ var ( | |||
| descNamespaceLabelsHelp = "Kubernetes labels converted to Prometheus labels." | |||
| descNamespaceLabelsDefaultLabels = []string{"namespace"} | |||
|
|
|||
| descNamespaceAnnotationsName = "kube_namespace_annotations" | |||
There was a problem hiding this comment.
Seems like we already had the kube_namespace_annotations metric before this addition, but this metric is marked as STABLE in our docs. Any suggestions for this? We can either remove it, but because it's marked as stable, I would say we try to filter out?
There was a problem hiding this comment.
We discussed this and we want to remove this.
Because we do not know what could be in the annotations that are created by kubernetes, we want to remove all annotation metrics.
|
Tested it locally, and this gets rid of all the annotation metrics. |
|
/lgtm Thanks for taking care of this! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, LiliC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This reverts commit 5ae00bb.
As discussed in #857 (comment) due to the need to filter out too many annotations created by kubernetes we want to revert this as it was marked as
EXPERIMENTALwe can do that, and rethink the annotation metrics in a separate PR.Closes #854
cc @tariq1890 @brancz
Note: we should forward this to master branch as well as open issue to rethink annotation metrics.