deployment: skip max unavailable if rolling update is unset #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously caused panics when objects did not have the RollingUpdate struct set.
k8s-ci-robot
added
the
cncf-cla: yes
matthiasr
approved these changes
Feb 10, 2017
|
👍 |
while1malloc0
pushed a commit
to while1malloc0/kube-state-metrics
that referenced
this pull request
Jul 2, 2018
deployment: skip max unavailable if rolling update is unset
rexagod
pushed a commit
to rexagod/kube-state-metrics
that referenced
this pull request
Oct 16, 2023
…ry-pick-85-to-release-4.10 [release-4.10] OCPBUGS-4086: cherry-pick, do not expose ingress path metric when service is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously caused panics when objects did not have the
RollingUpdate struct set.
I also validated, that the tests would now also panic, without the fix.
Closes #84. I'll create a patch release with this once the fix is merged.
@alexsomesan @fabxc
/cc @rvrignaud @stvnwrgs
This change is