Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the Static Pods as YAML files instead of JSON #153

Closed
luxas opened this issue Feb 9, 2017 · 2 comments
Closed

Store the Static Pods as YAML files instead of JSON #153

luxas opened this issue Feb 9, 2017 · 2 comments
Assignees
@dmmcquay
Milestone
v1.6

Comments

@luxas
Copy link
Member

luxas commented Feb 9, 2017

Right now, the Static Pods are stored as .json files in /etc/kubernetes/manifests.
I think we should store them instead as YAML as it's easier to read, more common etc.
Also when I mentioned that they are json files in the sig meeting I was asked why they aren't yaml files currently, which I think is a agreement with this issue.

And this is a thing we should do before going to beta.
@luxas luxas added this to the v1.6 milestone Feb 9, 2017
@luxas
Copy link
Member Author

luxas commented Feb 9, 2017

@dmmcquay Is this something you can pick up?

@dmmcquay
Copy link

@luxas yes, you can assign it to me.

@dmmcquay dmmcquay mentioned this issue Feb 10, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 11, 2017
Merge pull request #41260 from apprenda/kubeadm-153-yaml
3f2a25e 
Automatic merge from submit-queue (batch tested with PRs 41259, 41260)

kubeadm: changed manifest files to yaml

**What this PR does / why we need it**: Static Pods are currently stored as .json files in /etc/kubernetes/manifests. This PR instead writes them as YAML, as requested by the SIG.

**Which issue this PR fixes**: fixes #kubernetes/kubeadm#153

**Special notes for your reviewer**: /cc @luxas 

**Release note**:
```release-note
NONE
```
@luxas luxas closed this as completed Feb 11, 2017
@cncook001 cncook001 mentioned this issue Jul 5, 2018
Closed
@fishhead2zju fishhead2zju mentioned this issue Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmmcquay dmmcquay

Labels
None yet
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
2 participants
@dmmcquay @luxas