Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only the cluster-info ConfigMap should be exposed in the kube-public namespace #320

Closed
luxas opened this issue Jun 26, 2017 · 0 comments · Fixed by kubernetes/kubernetes#48050
Closed

Only the cluster-info ConfigMap should be exposed in the kube-public namespace #320

luxas opened this issue Jun 26, 2017 · 0 comments · Fixed by kubernetes/kubernetes#48050
Assignees
@luxas
Labels
area/security kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@luxas
Copy link
Member

luxas commented Jun 26, 2017

Currently it seems like all ConfigMaps in the kube-public namespace are, which is sub-optimal
This can and should be cherrypicked into the v1.6 and v1.7 releases.
PR: kubernetes/kubernetes#48050
@luxas luxas self-assigned this Jun 26, 2017
@luxas luxas added area/security kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 26, 2017
@luxas luxas mentioned this issue Jun 26, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Jun 28, 2017
Merge pull request #48050 from luxas/fix_rbac_configmaps
6089557 
Automatic merge from submit-queue

kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns

**What this PR does / why we need it**:

Noticed a bug; we should only expose the `cluster-info` ConfigMap.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

Fixes: kubernetes/kubeadm#320

**Special notes for your reviewer**:

Cherrypick-candidate for v1.8 cc @dchen1107 
Not blocking the release though...

**Release note**:

```release-note
NONE
```
@jbeda @pipejakob @timothysc @kubernetes/sig-cluster-lifecycle-pr-reviews
@luxas luxas closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luxas luxas

Labels
area/security kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns luxas/kubernetes
1 participant
@luxas