-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for "Config to v1beta1" #963
Comments
/assign @timothysc @liztio |
Automatic merge from submit-queue (batch tested with PRs 66136, 64999, 65425, 66120, 66074). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Printable default component configs **What this PR does / why we need it**: This PR makes default component configs printable via `kubeadm config print-default`. Component configs are not printed by default. You have to explicitly request that for concrete API objects via the `--api-objects` command line parameter. For a list of possible API objects use the help option. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Refs kubernetes/kubeadm#963 **Special notes for your reviewer**: /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /area kubeadm /assign @luxas /assign @timothysc /kind feature **Release note**: ```release-note kubeadm: Default component configs are printable via kubeadm config print-default ```
…images Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: use ClusterConfiguration in images.go **What this PR does / why we need it**: This PR is the first in a series, targeting the replacement of InitConfiguration with ClusterConfiguration, when the former is not needed. Please, review only the last commit. Replace the unnecessary use of InitConfiguration in images.go with ClusterConfiguration. This changes the interfaces of the following functions: - GetKubeControlPlaneImage - GetEtcdImage - GetAllImages **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: refs kubernetes/kubeadm#963 **Special notes for your reviewer**: /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /area kubeadm /kind enhancement /assign @luxas /assign @timothysc /assign @fabriziopandini Depends on: - [X] kubernetes#67441 **Release note**: ```release-note NONE ```
…ig-ControlPlaneEndpoint Automatic merge from submit-queue (batch tested with PRs 67776, 67503, 67679, 67786, 67830). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm config move ControlPlaneEndpoint to ClusterConfiguration **What this PR does / why we need it**: This PR moves `ControlPlaneEndpoint` from the `API` config struct to `ClusterConfiguration`. This change is required as initial step for enabling management of more than one control plane instances in kubeadm **Which issue(s) this PR fixes** : refs kubernetes/kubeadm#911, refs kubernetes/kubeadm#963 **Special notes for your reviewer**: just an appetizer, the main dish will be the next PR... **Release note**: ```release-note kubeadm: ControlPlaneEndpoint was moved from the API config struct to ClusterConfiguration ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /sig cluster-lifecycle /area kubeadm /kind api-change /kind enhancement /assign @luxas /assign @timothysc /cc @chuckha @rosti @neolit123 @liztio
…ig-APIEndpoint Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm config add support for more than one APIEndpoint **What this PR does / why we need it**: This PR completes the changes in kubeadm for management of more than one control plane instances introducing the possibility to configure more than one APIEndpoints **Which issue(s) this PR fixes** : refs kubernetes/kubeadm#911, refs kubernetes/kubeadm#963 **Special notes for your reviewer**: Depends on: - [x] kubernetes#67830 **Release note**: ```release-note kubeadm: The kubeadm configuration now support definition of more than one control plane instances with their own APIEndpoint. The APIEndpoint for the "bootstrap" control plane instance should be defined using `InitConfiguration.APIEndpoint`, while the APIEndpoints for additional control plane instances should be added using `JoinConfiguration.APIEndpoint`. ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /sig cluster-lifecycle /area kubeadm /kind api-change /kind enhancement /assign @luxas /assign @timothysc /cc @chuckha @rosti @neolit123 @liztio
…ig-configMap Automatic merge from submit-queue (batch tested with PRs 63011, 68089, 67944, 68132). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Kubeadm upload and fetch of kubeam config v1alpha3 **What this PR does / why we need it**: This PR implements upload and fetch of kubeam config v1alpha3 from cluster. More in detail: In upload, `kubeadm-config` gets - `ClusterConfiguration` (without components config which are already stored in separated ConfigMaps) - `ClusterStatus`(initialised or updated with the API endpoint of the current node) During fetch `InitConfiguration` is composed with: - `ClusterConfiguration` from `kubeadm-config` - The `APIEndpoint` of the current node from `ClusterStatus` in `kubeadm-config` - Component configs from corresponding ConfigMaps **Which issue(s) this PR fixes** : refs kubernetes/kubeadm#911, refs kubernetes/kubeadm#963 **Special notes for your reviewer**: In order to implement this it was necessary to extend current component config management with a new GetFromConfigMap operation. This is implemented in a separated commit " implement component configs GetFromConfigMap". The real change build on this (commi "upload and fetch kubeadm v1alpha3") **Release note**: ```release-note NONE ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews /sig cluster-lifecycle /area kubeadm /kind enhancement /assign @luxas /assign @timothysc /cc @chuckha @rosti @neolit123 @liztio
@timothysc @neolit123 |
+1 |
closing with lazy consensus 😉 |
Tracking issue for
v1beta1
related tasks.1.12 planning doc:
https://docs.google.com/document/d/1YP8sCtgo58yqQ9sR4nsn9iuVFmglCCBMivCTwjd1ERE/edit#
Write a KEP for the v1beta1 config API
@fabriziopandini @luxas
Kubeadm configfile beta community#2451
Based on gdocs proposal draft here: https://docs.google.com/document/d/1Sk2VW7IKaLjrjf_4a1NEU0l7X0ysZoXq9lVBvH-ruYY/edit#heading=h.jt5lxzh770he
related: Create a v1beta1 version for kubeadm config API types #911
Remove v1alpha1
@luxas
kubeadm: Remove the v1alpha1 API kubernetes#65628 and kubeadm: Stop using/supporting the v1alpha1 Config API kubernetes#65776
Create new v1alpha3 API
@luxas
We will rename to
v1beta1
at the end of the v1.12 cycle if we’re confident in itkubeadm: Add a
v1alpha3
API kubernetes#65629Move ComponentConfigs out to different YAML documents
@luxas
kubeadm: Add support for reading multiple YAML documents kubernetes#65631
@luxas
kubeadm: Start using internal versions for ComponentConfigs in the internal API kubernetes#65940
@luxas
kubeadm: Use separate YAML docs for the kubelet and kube-proxy ComponentConfigs kubernetes#65787
kubeadm config print-defaults --componentConfig
Add support for
kubeadm config print-defaults --api-objects {componentConfig}
#1126Don't upload the extra ComponentConfig YAML documents to the cluster configmap and on upgrade, fetch the components' ConfigMaps back
@fabriziopandini
Kubeadm upload and fetch of kubeam config v1alpha3 kubernetes#67944
Split cluster specification from runtime variables
MasterConfiguration
toInitConfiguration
@luxas
Rename
MasterConfiguration
toInitConfiguration
in the kubeadm v1alpha3 Config API kubernetes#65945NodeConfiguration
toJoinConfiguration
@luxas >> @fabriziopandini
Rename
NodeConfiguration
toJoinConfiguration
in the kubeadm v1alpha3 Config API kubernetes#65951@luxas >> @fabriziopandini
kubeadm: Make the kubeadm config kinds mutually exclusive kubernetes#65952
util/config/*
; filename and methods should be updated to use new namesCleanup
util/config
packages; filenames and methods should be updated to use new names #1125InitConfiguration
andClusterConfiguration
and Don't upload the extra
InitConfiguration
to the cluster configmap@luxas
kubeadm: Split out ClusterConfiguration from InitConfiguration kubernetes#66219 (HOLD)
@rosti
[reissue] kubeadm: Split out ClusterConfiguration from InitConfiguration kubernetes#67441
kubeadm: use ClusterConfiguration in images.go kubernetes#67503
further cleanups --> ISSUE Narrow down the usage of InitConfiguration throughout the code base #1084
Improve node/kubelet configuration by using substructs
Already done in v1alpha2
@fabriziopandini
Kubeadm upload and fetch of kubeam config v1alpha3 kubernetes#67944
Improve controlplane configuration by using substructs
Improve Etcd configuration by using substructs
Already done in v1alpha2
Improve bootstrap token configuration by using substructs
Already done in v1alpha2
Introduce support for clusters with n>1 controlplane instances
@fabriziopandini
kubeadm config move ControlPlaneEndpoint to ClusterConfiguration kubernetes#67830
kubeadm config add support for more than one APIEndpoint kubernetes#67832
Addons configuration
relevant issues:
v1beta1
Make the kube-proxy ComponentConfigv1beta1
#967Refactor the Discovery joining API types
Rationalize with Cluster APIMake flags override config values e.g. - NodeName override.
relevant issues:
etcd HA capabilities
Automate stacked etcd into kubeadm join --control-plane workflow #1123
Nix self hosting.
relevant issues:
kubeadm - deprecate feature-gates HighAvailability, SelfHosting, CertsInSecrets kubernetes#67786
Cleanup code for feature-gates HighAvailability, SelfHosting, CertsInSecrets #1072
The BootstrapTokenString object should move out to either k8s.io/client-go or k8s.io/api
relevant issues:
The text was updated successfully, but these errors were encountered: