add e2e test for etcd learner mode #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/kinder
pacoxu
force-pushed
the
add-learner-mode-test
branch
2 times, most recently
from
33a5cf8
to
2cac1d0
Compare
|
/assign @SataQiu |
k8s-ci-robot
added
the
needs-rebase
pacoxu
force-pushed
the
add-learner-mode-test
branch
from
2cac1d0
to
fc4e52d
Compare
k8s-ci-robot
removed
the
needs-rebase
SataQiu
reviewed
Jan 31, 2023
kinder/ci/tools/update-workflows/templates/workflows/learner-mode-tasks.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+8
to
+9
| kubernetesVersion: "\{\{ resolve `ci/{{ ciLabelFor .KubernetesVersion }}` \}\}" | ||
| upgradeVersion: "\{\{ resolve `ci/{{ ciLabelFor .KubernetesVersion }}` \}\}" |
There was a problem hiding this comment.
This means that we always upgrade to the current version, but that seems fine.
There was a problem hiding this comment.
The core part of this task is to join new control-planes. upgrade is just to make the process more complete.
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
pacoxu
force-pushed
the
add-learner-mode-test
branch
from
fc4e52d
to
d82f4a1
Compare
12 tasks
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#115038 is pending on this.
/assign @neolit123