Register metrics in init

kubernetes · Aug 23, 2017 · 1bf652a · 1bf652a
1 parent ae998cb
commit 1bf652a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/pkg/controller/volume/persistentvolume/pv_controller_base.go b/pkg/controller/volume/persistentvolume/pv_controller_base.go
@@ -75,8 +75,6 @@ func NewController(p ControllerParameters) (*PersistentVolumeController, error)
 		eventRecorder = broadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: "persistentvolume-controller"})
 	}
 
-	util.RegisterMetrics()
-
 	controller := &PersistentVolumeController{
 		volumes:           newPersistentVolumeOrderedIndex(),
 		claims:            cache.NewStore(cache.DeletionHandlingMetaNamespaceKeyFunc),

diff --git a/pkg/volume/util/metrics.go b/pkg/volume/util/metrics.go
@@ -17,35 +17,34 @@ limitations under the License.
 package util
 
 import (
-	"sync"
 	"time"
 
 	"github.com/prometheus/client_golang/prometheus"
 )
 
-var StorageOperationMetric = prometheus.NewHistogramVec(
+var storageOperationMetric = prometheus.NewHistogramVec(
 	prometheus.HistogramOpts{
 		Name: "storage_operation_duration_seconds",
 		Help: "Storage operation duration",
 	},
 	[]string{"volume_plugin", "operation_name"},
 )
 
-var StorageOperationErrorMetric = prometheus.NewCounterVec(
+var storageOperationErrorMetric = prometheus.NewCounterVec(
 	prometheus.CounterOpts{
 		Name: "storage_operation_errors_total",
 		Help: "Storage operation errors",
 	},
 	[]string{"volume_plugin", "operation_name"},
 )
 
-var registerMetrics sync.Once
+func init() {
+	registerMetrics()
+}
 
-func RegisterMetrics() {
-	registerMetrics.Do(func() {
-		prometheus.MustRegister(StorageOperationMetric)
-		prometheus.MustRegister(StorageOperationErrorMetric)
-	})
+func registerMetrics() {
+	prometheus.MustRegister(storageOperationMetric)
+	prometheus.MustRegister(storageOperationErrorMetric)
 }
 
 // OperationCompleteHook returns a hook to call when an operation is completed
@@ -55,9 +54,9 @@ func OperationCompleteHook(plugin, operationName string) func(error) {
 		timeTaken := time.Since(requestTime).Seconds()
 		// Create metric with operation name and plugin name
 		if err != nil {
-			StorageOperationErrorMetric.WithLabelValues(plugin, operationName).Inc()
+			storageOperationErrorMetric.WithLabelValues(plugin, operationName).Inc()
 		} else {
-			StorageOperationMetric.WithLabelValues(plugin, operationName).Observe(timeTaken)
+			storageOperationMetric.WithLabelValues(plugin, operationName).Observe(timeTaken)
 		}
 	}
 	return opComplete

diff --git a/pkg/volume/util/operationexecutor/operation_executor.go b/pkg/volume/util/operationexecutor/operation_executor.go
@@ -125,8 +125,6 @@ type OperationExecutor interface {
 func NewOperationExecutor(
 	operationGenerator OperationGenerator) OperationExecutor {
 
-	util.RegisterMetrics()
-
 	return &operationExecutor{
 		pendingOperations: nestedpendingoperations.NewNestedPendingOperations(
 			true /* exponentialBackOffOnError */),