Skip to content

Commit

Permalink
[Federation][(Un)join-00] Implement federation/cluster resource gener…
Browse files Browse the repository at this point in the history
…ator.
  • Loading branch information
madhusudancs committed Oct 19, 2016
1 parent cb03ed3 commit 4c1eb90
Show file tree
Hide file tree
Showing 3 changed files with 291 additions and 0 deletions.
110 changes: 110 additions & 0 deletions pkg/kubectl/cluster.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
/*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package kubectl

import (
"fmt"

federationapi "k8s.io/kubernetes/federation/apis/federation/v1beta1"
"k8s.io/kubernetes/pkg/api/v1"
"k8s.io/kubernetes/pkg/runtime"
)

// ClusterGeneratorV1Beta1 supports stable generation of a
// federation/cluster resource.
type ClusterGeneratorV1Beta1 struct {
// Name of the cluster context (required)
Name string
// ServerAddress is the APIServer address of the Kubernetes cluster
// that is being registered (optional)
ServerAddress string
// SecretName is the name of the secret that stores the credentials
// for the Kubernetes cluster that is being registered (optional)
SecretName string
}

// Ensure it supports the generator pattern that uses parameter
// injection.
var _ Generator = &ClusterGeneratorV1Beta1{}

// Ensure it supports the generator pattern that uses parameters
// specified during construction.
var _ StructuredGenerator = &ClusterGeneratorV1Beta1{}

// Generate returns a cluster resource using the specified parameters.
func (s ClusterGeneratorV1Beta1) Generate(genericParams map[string]interface{}) (runtime.Object, error) {
err := ValidateParams(s.ParamNames(), genericParams)
if err != nil {
return nil, err
}
clustergen := &ClusterGeneratorV1Beta1{}
params := map[string]string{}
for key, value := range genericParams {
strVal, isString := value.(string)
if !isString {
return nil, fmt.Errorf("expected string, saw %v for '%s'", value, key)
}
params[key] = strVal
}
clustergen.Name = params["name"]
clustergen.ServerAddress = params["serverAddress"]
clustergen.SecretName = params["secret"]
return clustergen.StructuredGenerate()
}

// ParamNames returns the set of supported input parameters when using
// the parameter injection generator pattern.
func (s ClusterGeneratorV1Beta1) ParamNames() []GeneratorParam {
return []GeneratorParam{
{"name", true},
{"serverAddress", false},
{"secret", false},
}
}

// StructuredGenerate outputs a federation cluster resource object
// using the configured fields.
func (s ClusterGeneratorV1Beta1) StructuredGenerate() (runtime.Object, error) {
if err := s.validate(); err != nil {
return nil, err
}
cluster := &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: s.Name,
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: s.ServerAddress,
},
},
SecretRef: &v1.LocalObjectReference{
Name: s.SecretName,
},
},
}
return cluster, nil
}

// validate validates required fields are set to support structured
// generation.
func (s ClusterGeneratorV1Beta1) validate() error {
if len(s.Name) == 0 {
return fmt.Errorf("name must be specified")
}
return nil
}
180 changes: 180 additions & 0 deletions pkg/kubectl/cluster_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,180 @@
/*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package kubectl

import (
"reflect"
"testing"

federationapi "k8s.io/kubernetes/federation/apis/federation/v1beta1"
"k8s.io/kubernetes/pkg/api/v1"
)

func TestClusterGenerate(t *testing.T) {
tests := []struct {
params map[string]interface{}
expected *federationapi.Cluster
expectErr bool
}{
{
params: map[string]interface{}{
"name": "foo",
},
expected: &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: "foo",
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: "",
},
},
SecretRef: &v1.LocalObjectReference{
Name: "",
},
},
},
expectErr: false,
},
{
params: map[string]interface{}{
"name": "foo",
"serverAddress": "10.20.30.40",
},
expected: &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: "foo",
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: "10.20.30.40",
},
},
SecretRef: &v1.LocalObjectReference{
Name: "",
},
},
},
expectErr: false,
},
{
params: map[string]interface{}{
"name": "foo",
"secret": "foo-credentials",
},
expected: &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: "foo",
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: "",
},
},
SecretRef: &v1.LocalObjectReference{
Name: "foo-credentials",
},
},
},
expectErr: false,
},
{
params: map[string]interface{}{
"name": "foo",
"serverAddress": "https://foo.example.com",
"secret": "foo-credentials",
},
expected: &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: "foo",
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: "https://foo.example.com",
},
},
SecretRef: &v1.LocalObjectReference{
Name: "foo-credentials",
},
},
},
expectErr: false,
},
{
params: map[string]interface{}{
"name": "bar-cluster",
"serverAddress": "http://10.20.30.40",
"secret": "credentials",
},
expected: &federationapi.Cluster{
ObjectMeta: v1.ObjectMeta{
Name: "bar-cluster",
},
Spec: federationapi.ClusterSpec{
ServerAddressByClientCIDRs: []federationapi.ServerAddressByClientCIDR{
{
ServerAddress: "http://10.20.30.40",
},
},
SecretRef: &v1.LocalObjectReference{
Name: "credentials",
},
},
},
expectErr: false,
},
{
params: map[string]interface{}{
"serverAddress": "https://10.20.30.40",
},
expected: nil,
expectErr: true,
},
{
params: map[string]interface{}{
"secret": "baz-credentials",
},
expected: nil,
expectErr: true,
},
{
params: map[string]interface{}{
"serverAddress": "http://foo.example.com",
"secret": "foo-credentials",
},
expected: nil,
expectErr: true,
},
}
generator := ClusterGeneratorV1Beta1{}
for i, test := range tests {
obj, err := generator.Generate(test.params)
if !test.expectErr && err != nil {
t.Errorf("[%d] unexpected error: %v", i, err)
}
if test.expectErr && err != nil {
continue
}
if !reflect.DeepEqual(obj.(*federationapi.Cluster), test.expected) {
t.Errorf("\n[%d] want:\n%#v\n[%d] got:\n%#v", i, test.expected, i, obj.(*federationapi.Cluster))
}
}
}
1 change: 1 addition & 0 deletions pkg/kubectl/cmd/util/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ const (
SecretForDockerRegistryV1GeneratorName = "secret-for-docker-registry/v1"
SecretForTLSV1GeneratorName = "secret-for-tls/v1"
ConfigMapV1GeneratorName = "configmap/v1"
ClusterV1Beta1GeneratorName = "cluster/v1beta1"
)

// DefaultGenerators returns the set of default generators for use in Factory instances
Expand Down

0 comments on commit 4c1eb90

Please sign in to comment.