Skip to content

Commit

Permalink
remove GA featuregates: CSIInlineVolume, CSIMigration, DaemonSetUpdat…
Browse files Browse the repository at this point in the history
…eSurge, EphemeralContainers, IdentifyPodOS, LocalStorageCapacityIsolation, NetworkPolicyEndPort, StatefulSetMinReadySeconds
  • Loading branch information
SataQiu committed Dec 11, 2022
1 parent 47d5826 commit 4c60ee0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 89 deletions.
78 changes: 0 additions & 78 deletions pkg/features/kube_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,21 +108,6 @@ const (
// Allow the usage of options to fine-tune the cpumanager policies.
CPUManagerPolicyOptions featuregate.Feature = "CPUManagerPolicyOptions"

// owner: @pohly
// alpha: v1.14
// beta: v1.16
// GA: v1.25
//
// Enables CSI Inline volumes support for pods
CSIInlineVolume featuregate.Feature = "CSIInlineVolume"

// owner: @davidz627
// alpha: v1.14
// beta: v1.17
//
// Enables the in-tree storage to CSI Plugin migration feature.
CSIMigration featuregate.Feature = "CSIMigration"

// owner: @leakingtapan
// alpha: v1.14
// beta: v1.17
Expand Down Expand Up @@ -223,13 +208,6 @@ const (
// Enables support for time zones in CronJobs.
CronJobTimeZone featuregate.Feature = "CronJobTimeZone"

// owner: @smarterclayton
// alpha: v1.21
// beta: v1.22
// GA: v1.25
// DaemonSets allow workloads to maintain availability during update per node
DaemonSetUpdateSurge featuregate.Feature = "DaemonSetUpdateSurge"

// owner: @gnufied, @verult, @bertinatto
// alpha: v1.22
// beta: v1.23
Expand Down Expand Up @@ -291,14 +269,6 @@ const (
// Enable Terminating condition in Endpoint Slices.
EndpointSliceTerminatingCondition featuregate.Feature = "EndpointSliceTerminatingCondition"

// owner: @verb
// alpha: v1.16
// beta: v1.23
// GA: v1.25
//
// Allows running an ephemeral container in pod namespaces to troubleshoot a running pod.
EphemeralContainers featuregate.Feature = "EphemeralContainers"

// owner: @harche
// kep: http://kep.k8s.io/3386
// alpha: v1.25
Expand Down Expand Up @@ -391,14 +361,6 @@ const (
// deletion ordering.
HonorPVReclaimPolicy featuregate.Feature = "HonorPVReclaimPolicy"

// owner: @ravig
// alpha: v1.23
// beta: v1.24
// GA: v1.25
// IdentifyPodOS allows user to specify OS on which they'd like the Pod run. The user should still set the nodeSelector
// with appropriate `kubernetes.io/os` label for scheduler to identify appropriate node for the pod to run.
IdentifyPodOS featuregate.Feature = "IdentifyPodOS"

// owner: @leakingtapan
// alpha: v1.21
//
Expand Down Expand Up @@ -539,13 +501,6 @@ const (
// Enables tracking of secret-based service account tokens usage.
LegacyServiceAccountTokenTracking featuregate.Feature = "LegacyServiceAccountTokenTracking"

// owner: @jinxu
// beta: v1.10
// stable: v1.25
//
// Support local ephemeral storage types for local storage capacity isolation feature.
LocalStorageCapacityIsolation featuregate.Feature = "LocalStorageCapacityIsolation"

// owner: @RobertKrawitz
// alpha: v1.15
//
Expand Down Expand Up @@ -617,15 +572,6 @@ const (
// Enables the MultiCIDR Range allocator.
MultiCIDRRangeAllocator featuregate.Feature = "MultiCIDRRangeAllocator"

// owner: @rikatz
// kep: https://kep.k8s.io/2079
// alpha: v1.21
// beta: v1.22
// ga: v1.25
//
// Enables the endPort field in NetworkPolicy to enable a Port Range behavior in Network Policies.
NetworkPolicyEndPort featuregate.Feature = "NetworkPolicyEndPort"

// owner: @rikatz
// kep: https://kep.k8s.io/2943
// alpha: v1.24
Expand Down Expand Up @@ -796,14 +742,6 @@ const (
// Enables policies controlling deletion of PVCs created by a StatefulSet.
StatefulSetAutoDeletePVC featuregate.Feature = "StatefulSetAutoDeletePVC"

// owner: @ravig
// kep: https://kep.k8s.io/2607
// alpha: v1.22
// beta: v1.23
// GA: v1.25
// StatefulSetMinReadySeconds allows minReadySeconds to be respected by StatefulSet controller
StatefulSetMinReadySeconds featuregate.Feature = "StatefulSetMinReadySeconds"

// owner: @psch
// alpha: v1.26
//
Expand Down Expand Up @@ -939,10 +877,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

CPUManagerPolicyOptions: {Default: true, PreRelease: featuregate.Beta},

CSIInlineVolume: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

CSIMigration: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

CSIMigrationAWS: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

CSIMigrationAzureDisk: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.26
Expand Down Expand Up @@ -971,8 +905,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

CronJobTimeZone: {Default: true, PreRelease: featuregate.Beta},

DaemonSetUpdateSurge: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

DelegateFSGroupToCSIDriver: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28

DevicePlugins: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.26
Expand All @@ -989,8 +921,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

DynamicResourceAllocation: {Default: false, PreRelease: featuregate.Alpha},

EphemeralContainers: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

EventedPLEG: {Default: false, PreRelease: featuregate.Alpha},

ExecProbeTimeout: {Default: true, PreRelease: featuregate.GA}, // lock to default and remove after v1.22 based on KEP #1972 update
Expand All @@ -1015,8 +945,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

HonorPVReclaimPolicy: {Default: false, PreRelease: featuregate.Alpha},

IdentifyPodOS: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

InTreePluginAWSUnregister: {Default: false, PreRelease: featuregate.Alpha},

InTreePluginAzureDiskUnregister: {Default: false, PreRelease: featuregate.Alpha},
Expand Down Expand Up @@ -1057,8 +985,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

LegacyServiceAccountTokenTracking: {Default: false, PreRelease: featuregate.Alpha},

LocalStorageCapacityIsolation: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: false, PreRelease: featuregate.Alpha},

LogarithmicScaleDown: {Default: true, PreRelease: featuregate.Beta},
Expand All @@ -1079,8 +1005,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

MultiCIDRRangeAllocator: {Default: false, PreRelease: featuregate.Alpha},

NetworkPolicyEndPort: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

NetworkPolicyStatus: {Default: false, PreRelease: featuregate.Alpha},

NodeOutOfServiceVolumeDetach: {Default: true, PreRelease: featuregate.Beta},
Expand Down Expand Up @@ -1127,8 +1051,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

StatefulSetAutoDeletePVC: {Default: false, PreRelease: featuregate.Alpha},

StatefulSetMinReadySeconds: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.27

StatefulSetStartOrdinal: {Default: false, PreRelease: featuregate.Alpha},

TopologyAwareHints: {Default: true, PreRelease: featuregate.Beta},
Expand Down
6 changes: 0 additions & 6 deletions pkg/kubelet/eviction/eviction_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,6 @@ func TestMemoryPressure_VerifyPodStatus(t *testing.T) {
}

func TestDiskPressureNodeFs_VerifyPodStatus(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()

testCases := map[string]struct {
wantPodStatus v1.PodStatus
}{
Expand Down Expand Up @@ -652,8 +650,6 @@ func parseQuantity(value string) resource.Quantity {
}

func TestDiskPressureNodeFs(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()

podMaker := makePodWithDiskStats
summaryStatsMaker := makeDiskStats
podsToMake := []podToMake{
Expand Down Expand Up @@ -989,8 +985,6 @@ func TestMinReclaim(t *testing.T) {
}

func TestNodeReclaimFuncs(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()

podMaker := makePodWithDiskStats
summaryStatsMaker := makeDiskStats
podsToMake := []podToMake{
Expand Down
5 changes: 0 additions & 5 deletions pkg/kubelet/eviction/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,8 @@ import (
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
utilfeature "k8s.io/apiserver/pkg/util/feature"
featuregatetesting "k8s.io/component-base/featuregate/testing"
statsapi "k8s.io/kubelet/pkg/apis/stats/v1alpha1"

"k8s.io/kubernetes/pkg/features"
evictionapi "k8s.io/kubernetes/pkg/kubelet/eviction/api"
kubetypes "k8s.io/kubernetes/pkg/kubelet/types"
)
Expand Down Expand Up @@ -815,7 +812,6 @@ func TestOrderedbyDisk(t *testing.T) {
}

func TestOrderedbyInodes(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()
low := newPod("low", defaultPriority, []v1.Container{
newContainer("low", newResourceList("", "", ""), newResourceList("", "", "")),
}, []v1.Volume{
Expand Down Expand Up @@ -858,7 +854,6 @@ func TestOrderedbyInodes(t *testing.T) {

// TestOrderedByPriorityDisk ensures we order pods by priority and then greediest resource consumer
func TestOrderedByPriorityDisk(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()
pod1 := newPod("above-requests-low-priority-high-usage", lowPriority, []v1.Container{
newContainer("above-requests-low-priority-high-usage", newResourceList("", "", ""), newResourceList("", "", "")),
}, []v1.Volume{
Expand Down

0 comments on commit 4c60ee0

Please sign in to comment.