[sig-apps] Daemon set [Serial] should not update pod when spec was updated and update strategy is OnDelete

[jberkus]

DaemonSet upgrades and downgrades have been failing since 9/25.

Dashboard: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

Sample Failure: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-new-master-upgrade-master/1803

This test failure will block 1.13 beta, so please let's fix it before then. Thanks!

/sig apps
/kind failing-test
/priority important-soon

[mortent]

I'm investigating this.
It is related to the change here: #68754. Still figuring out the actual impact and how to fix it.

[jberkus]

cc

@bradhoekstra

@thockin

@bboreham

[mortent]

/assign

[AishSundar]

FWIW there's one more related test failure - #67903

[bradhoekstra]

This is also being discussed in this issue: #69445

[bradhoekstra]

Any opinions on whether the suggestion by @kow3ns here is the correct approach for fixing this?

[jberkus]

I'm escalating this issue to critical-urgent.

At this point, not resolving this is keeping us from verifying the upgrade tests. Because the Daemonsets have been failing for weeks, at this point we don't know what other upgrade test job failures that may be masking, and whether any of the other test flakes are related to the Daemonset failure. This needs to be resolved, ASAP.

/priority critical-urgent

[jberkus]

/remove-priority important-soon

[AishSundar]

@jberkus #69988 which just merged claims to fix this issue. lets watch for the next run.

[nikopen]

DaemonSet tests passed on run 1842, seems to have been fixed: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

if it doesn't pop up again -

/close

[k8s-ci-robot]

@nikopen: Closing this issue.

In response to this:

DaemonSet tests passed on run 1842, seems to have been fixed: https://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-new-master-upgrade-master

if it doesn't pop up again -

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.