-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downwardAPI volumes should also have hugepages-<size> exposed to the pod through resourceFieldRef. #85148
Comments
@kubernetes/sig-node-feature-requests |
@DeySouvik: Reiterating the mentions to trigger a notification: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage unresolved Comment 🤖 I am a bot run by vllry. 👩🔬 |
It looks like this ended up with a few too many sigs assigned, removing the ones that are not related, though I think this may only actually be relevant to sig-node. /remove-sig network service-catalog instrumentation architecture |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
/remove-lifecycle rotten |
@odinuge: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Currently the resourceFieldRef only exposes the cpu/memory and ephemeral-storage limit and requests to the POD. The hugepages information is not retrieve through the same mechanism.
POD manifest :
apiVersion: v1
kind: Pod
metadata:
name: isbc
namespace: development
labels:
name: isbc
annotations:
k8s.v1.cni.cncf.io/networks: pkt0-conf, pkt0-conf, pkt1-conf
spec:
nodeName: "node2"
hostname: "vsbc1"
containers:
image: artifact1.eng.sonusnet.com:8443/sbx-docker-prod-westford/isbc/sbc-image:latest
imagePullPolicy: IfNotPresent
command: ["/bin/bash","-c", "sleep 2000000000000"]
securityContext:
capabilities:
add:
- NET_ADMIN
allowPrivilegeEscalation: false
volumeMounts:
name: hugepage
resources:
limits:
hugepages-2Mi: "2048Mi"
memory: "16Gi"
cpu: "8"
ephemeral-storage: "100Gi"
volumeMounts:
mountPath: /etc/podinfo
readOnly: false
volumes:
emptyDir:
medium: HugePages
downwardAPI:
items:
- path: "cpu"
resourceFieldRef:
containerName: isbc
resource: limits.cpu
- path: "memory"
resourceFieldRef:
containerName: isbc
resource: limits.memory
divisor: 1Mi
- path: "storage"
resourceFieldRef:
containerName: isbc
resource: limits.ephemeral-storage
divisor: 1Mi
- path: "hugepages"
resourceFieldRef:
containerName: isbc
resource: limits.hugepages-2Mi
divisor: 1Mi
- path: "uid"
fieldRef:
fieldPath: metadata.uid
The above manifest fails the validation as the value limits.hugepages- is not supported.
[root@node1 ~]# kubectl create -f abc_pod.yml
The Pod "isbc" is invalid:
[root@node1 ~]#
Why is this needed:
As we are running dpdk and other real time apps it is required to know the number of hugepages allocated for the pod. We need to have both the limit and request for the hugepages- reported back to the pod as a part of the resourceFieldRef in the downwardAPI. This will help in allocating the proper number of hugepages to the apps in the POD.
The text was updated successfully, but these errors were encountered: