Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to set default container #95293

Closed
zeromsi opened this issue Oct 5, 2020 · 9 comments
Closed

Need a way to set default container #95293

zeromsi opened this issue Oct 5, 2020 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@zeromsi
Copy link

zeromsi commented Oct 5, 2020

Need an attribute that holds the name of default container or a flag that states which container is default.

@zeromsi zeromsi added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 5, 2020
@zeromsi
Copy link
Author

zeromsi commented Oct 5, 2020

/sig cli
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 5, 2020
@dougsland
Copy link
Member

Looks like dup request: #61333

@eddiezane
Copy link
Member

/assign @dougsland
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2020
@soltysh
Copy link
Contributor

soltysh commented Oct 15, 2020

Spoke with Doug, but for clarity the approach is to do something similar to #87809
but instead of kubectl.kubernetes.io/default-logs-container annotation we should introduce more generic like kubectl.kubernetes.io/default-container that can be used across the board.

@pacoxu
Copy link
Member

pacoxu commented Dec 2, 2020

/cc
@dougsland @soltysh

kubectl.kubernetes.io/default-container is annotation for kubectl
If we use go client or other cli, which is the default? kubectl annotation is not that generic.

@dougsland
Copy link
Member

/cc
@dougsland @soltysh

kubectl.kubernetes.io/default-container is annotation for kubectl
If we use go client or other cli, which is the default? kubectl annotation is not that generic.

My understanding from speaking with @soltysh is use the annotation.

@dougsland
Copy link
Member

We should close this one and mark as dup of #96986 as @pacoxu already started working on it.

@dougsland
Copy link
Member

/close
dup of #96986

@k8s-ci-robot
Copy link
Contributor

@dougsland: Closing this issue.

In response to this:

/close
dup of #96986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants