cluster: fix metrics-server deployment on CI jobs #103713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/failing-test
|
/assign @liggitt |
k8s-ci-robot
added
the
lgtm
liggitt
reviewed
Jul 15, 2021
|
/test |
|
@aojea: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-kubernetes-e2e-gce-iscsi |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/retest |
aojea
force-pushed
the
metrics-server-443
branch
from
38092b9 to
fb2f0d2
Compare
|
/test pull-kubernetes-e2e-gce-ubuntu |
added 2 commits
July 22, 2021 01:06
use deployment based on upstream manifest - add liveness and readiness probes - use kubelet port secure port https://github.com/kubernetes-sigs/metrics-server/blob/release-0.4/manifests/base/deployment.yaml#L32-L38
aojea
force-pushed
the
metrics-server-443
branch
from
3c3b0a1 to
0610968
Compare
k8s-ci-robot
added
size/M
|
/test pull-kubernetes-integration |
|
it works using the latest image , however, ti seems that the setcap fix was backported to the 0.4 branch and promoted correctly @serathius does it makes any sense to you? |
|
/approve @aojea if you need this for 1.22, please add a milestone and give a description/justification for @kubernetes/release-team as a comment. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@aojea To my knowledge, there are no differences between v0.4.4 and v0.5.0 that would change the behavior that we were seeing before. So there should be no risks with moving forward with v0.5.0 with the exception of maybe missing a real bug with dockershim. In case I double-checked the capabilities of the official images and they are the same: $ docker cp $(docker create --rm k8s.gcr.io/metrics-server/metrics-server:v0.4.4):metrics-server /tmp/metrics-server && getcap /tmp/metrics-server
/tmp/metrics-server cap_net_bind_service=ep
$ docker cp $(docker create --rm k8s.gcr.io/metrics-server/metrics-server:v0.5.0):metrics-server /tmp/metrics-server && getcap /tmp/metrics-server
/tmp/metrics-server cap_net_bind_service=ep |
Yes, please backport to |
|
/lgtm |
|
looks like there is consensus to apply this in 1.22 and fail a cherry-pick. /milestone v1.22 @aojea please file a cherry-pick to 1.22 branch |
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 23, 2021
…3-upstream-release-1.22 Automated cherry pick of #103713: cluster: fix CI metrics-server deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind failing-test
/kind flake
Fixes #103708
The metrics-server deployed wasn't working correctly due to the recent changes in kubernetes.
Surprisingly, the metrics-server was constantly crash looping but the tests were passing.
This PR fixes the metrics-server deployment: