-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WhoAmI flaky test #112471
Fix WhoAmI flaky test #112471
Conversation
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @nabokihms. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign aojea |
/sig auth |
/ok-to-test |
@@ -191,7 +192,14 @@ func printTableSelfSubjectAccessReview(obj runtime.Object, out io.Writer) error | |||
} | |||
|
|||
if len(ui.Extra) > 0 { | |||
for k, v := range ui.Extra { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sets.StringKeySet will do this for you:
for _, k := range sets.StringKeySet(ui.Extra).List() {
v := ui.Extra[k]
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, nabokihms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: m.nabokikh maksim.nabokikh@flant.com
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
Flaky test
Which issue(s) this PR fixes:
Fixes #112465
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: