Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e test for kubectl default container annotation #115046

Merged
merged 1 commit into from
Jan 16, 2023
Merged

add e2e test for kubectl default container annotation #115046

merged 1 commit into from
Jan 16, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 13, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#3457

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl: add e2e test for default container annotation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/2227-kubectl-default-container/README.md

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2023
@pacoxu pacoxu mentioned this pull request Jan 13, 2023
Merged
soltysh
soltysh reviewed Jan 13, 2023
View reviewed changes
test/e2e/kubectl/default_container.go Outdated
f := framework.NewDefaultFramework("default-container")
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelBaseline

ginkgo.Describe("logs", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, can you move all the kubectl logs related tests over to this file, and rename it to logs.go this way we'll start splitting that gigantic https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubectl/kubectl.go into smaller pieces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done in a followup.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Jan 16, 2023

/test pull-kubernetes-node-e2e-containerd

@pacoxu pacoxu marked this pull request as ready for review January 16, 2023 09:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Jan 16, 2023

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 16, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 16, 2023
@pacoxu pacoxu mentioned this pull request Jan 16, 2023
Closed
13 tasks
@pacoxu pacoxu force-pushed the default-container-e2e branch 3 times, most recently from c18bf17 to 37516d3 Compare January 16, 2023 12:13
@pacoxu
move kubectl log e2e to new file & add e2e test for kubectl default c…
b45f0a8 
…ontainer annotation

Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jan 16, 2023
soltysh
soltysh approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
It would be nice to split this into 2 commits:

  1. move existing test to new file
  2. add the new e2e

test/e2e/kubectl/logs.go
}
}

// TODO promote to conformance test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: drop this, not needed.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9474a0b9028f163bd6136237c2706d0ef92c12ee

@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2023

/assign @dims
for conformance approval
Dims this is just moving the pre-existing conformance test about kubect logs from that one gigantic kubectl.go file into smaller, more manageable pieces, and adds a new test covering that area (not conformance test).

@dims
Copy link
Member

dims commented Jan 16, 2023

/approve
/lgtm

thanks for the context @soltysh

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pacoxu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 62d7937 into kubernetes:master Jan 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 16, 2023
@pacoxu pacoxu mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

Assignees

@dims dims

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
4 participants
@pacoxu @k8s-ci-robot @soltysh @dims