Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for StatefulSetStartOrdinal feature #115466

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Add integration tests for StatefulSetStartOrdinal feature #115466

merged 2 commits into from
Feb 3, 2023

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Feb 2, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add integration test for KEP-3335:

Special notes for your reviewer:

Adding integration test for Beta promotion in 1.27

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 2, 2023
@pwschuurman pwschuurman mentioned this pull request Feb 2, 2023
Open
18 tasks
@pwschuurman
Move expensive test setup (apiserver and running controller) to be ru…
bc211bf 
…n once in StatefulSetStartOrdinal parameterized tests
@pwschuurman pwschuurman mentioned this pull request Feb 3, 2023
Merged
soltysh
soltysh approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a73bd6513f6a9ec5d2f93f15c5730c4558b4b310

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@soltysh
Copy link
Contributor

soltysh commented Feb 3, 2023

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7bf175d into kubernetes:master Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 3, 2023
karan2704 pushed a commit to karan2704/kubernetes that referenced this pull request Feb 6, 2023
@pwschuurman @karan2704
Add integration tests for StatefulSetStartOrdinal feature (kubernetes…
06ef9d8 
…#115466)

* Add integration tests for StatefulSetStartOrdinal feature

* Move expensive test setup (apiserver and running controller) to be run once in StatefulSetStartOrdinal parameterized tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@soltysh soltysh soltysh approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
4 participants
@pwschuurman @k8s-ci-robot @soltysh @aojea