Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidateVolumeAttributesClassUpdate also validates new vac object. #122449

Merged
merged 1 commit into from
Jan 3, 2024
Merged

ValidateVolumeAttributesClassUpdate also validates new vac object. #122449

merged 1 commit into from
Jan 3, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Dec 22, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

ValidateVolumeAttributesClassUpdate also validates new vac object.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

this func has already validate the meta object updates. the parameter and driverName field are immutable. so this changes won't have any effect on user's usage.

Does this PR introduce a user-facing change?

ValidateVolumeAttributesClassUpdate also validates new vac object.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2023
@carlory
Copy link
Member Author

carlory commented Dec 22, 2023

/cc @msau42 @sunnylovestiramisu

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c24525f0579c67347f23e51e94a46aa3b8e008ff

@carlory
Copy link
Member Author

carlory commented Dec 29, 2023

/assign thockin

@thockin
Copy link
Member

thockin commented Jan 3, 2024

Is there any way that a user out in the world could have somehow updated a saved object into a bad state that would no longer pass this validation?

@carlory
Copy link
Member Author

carlory commented Jan 3, 2024

No, there's no way for users to do that. we have already validate the meta field of the new obj and other fields are immutable. This PR is just to make sure that we don't have any bad data if we add new mutable fields in the future.

@thockin
Copy link
Member

thockin commented Jan 3, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit c015565 into kubernetes:master Jan 3, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

@msau42 msau42 Awaiting requested review from msau42

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@thockin thockin

@sunnylovestiramisu sunnylovestiramisu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
4 participants
@carlory @k8s-ci-robot @sunnylovestiramisu @thockin