Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publishing-bot rules to Go 1.22.6 #126989

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Update publishing-bot rules to Go 1.22.6 #126989

merged 2 commits into from
Aug 29, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 29, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update publishing-bot rules to Go 1.22.6

Which issue(s) this PR fixes:

xref kubernetes/release#3723

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @saschagrunert @xmudrii @dims
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 29, 2024
@cpanato cpanato mentioned this pull request Aug 29, 2024
Closed
15 tasks
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2024
xmudrii
xmudrii approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@xmudrii
Copy link
Member

xmudrii commented Aug 29, 2024

/retest

@xmudrii
Copy link
Member

xmudrii commented Aug 29, 2024

/lgtm cancel
@cpanato looks like this is a legitimate failure

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from xmudrii August 29, 2024 08:36
@cpanato
Update publishing-bot rules to Go 1.22.6
8e1ba3b 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Aug 29, 2024

@dims, should we remove the release-1.27 as it is deprecated?

@dims
Copy link
Member

dims commented Aug 29, 2024

@dims, should we remove the release-1.27 as it is deprecated?

yes please! (we are not going to do any more releases from that branch right?)

@dims
Copy link
Member

dims commented Aug 29, 2024

cc @akhilerm

@cpanato
Copy link
Member Author

cpanato commented Aug 29, 2024

@dims, should we remove the release-1.27 as it is deprecated?

yes please! (we are not going to do any more releases from that branch right?)

ok i will do that in this pr, and yes no more releases for 1.27

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2024
@cpanato
Copy link
Member Author

cpanato commented Aug 29, 2024

done @dims PTAL

@cpanato
drop rules for release-1.27 as this branch is EOL
dec204d 
Signed-off-by: cpanato <ctadeu@gmail.com>
@dims
Copy link
Member

dims commented Aug 29, 2024

/approve
/lgtm

thanks @cpanato !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 43db4efd17eb7e41a77ffc62994ffad30d4e7c08

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit baf11b0 into kubernetes:master Aug 29, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 29, 2024
akhilerm
akhilerm reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato deleted the update-rules branch August 29, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilerm akhilerm akhilerm left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@puerco puerco Awaiting requested review from puerco

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@dims dims

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @k8s-ci-robot @xmudrii @dims @saschagrunert @akhilerm