Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Deployment example for kubectl expose. #23222

Conversation

madhusudancs
Copy link
Contributor

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test failed for commit 749382e74435185e8a3e7c76cf180dc9ef9c834d.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@madhusudancs madhusudancs force-pushed the kubectl-expose-deployment-example branch from 749382e to 67b70d7 Compare March 19, 2016 00:06
@@ -72,6 +72,9 @@ kubectl expose rc streamer --port=4100 --protocol=udp --name=video-stream

# Create a service for a replicated nginx using replica set, which serves on port 80 and connects to the containers on port 8000.
kubectl expose rs nginx --port=80 --target-port=8000

# Create a service for an nginx deployment, which serves on port 80 and connects to the containers on port 8000.
kubectl expose deployment nginx --port=80 --target-port=8000
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johndmulhausen @bgrant0607 What's the process to copy these changes to the docs repo?

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 19, 2016

GCE e2e build/test passed for commit 67b70d7.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 19, 2016

GCE e2e build/test passed for commit 67b70d7.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 19, 2016
@k8s-github-robot k8s-github-robot merged commit 2c5903a into kubernetes:master Mar 19, 2016
@bgrant0607
Copy link
Member

Not critical enough to cherrypick.

@bgrant0607
Copy link
Member

Will think about cherrypick a bit more, since a user reported this as confusing. #23231

@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 23, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 24, 2016
…deployment-example

Auto commit by PR queue bot
(cherry picked from commit 2c5903a)
@bgrant0607 bgrant0607 added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 24, 2016
@k8s-cherrypick-bot
Copy link

Commit ffa1aa3 found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this s an error find help to get your PR picked.

AlainRoy pushed a commit to vmware-archive/kubernetes-archived that referenced this pull request Mar 29, 2016
…deployment-example

Auto commit by PR queue bot
(cherry picked from commit 2c5903a)
alena1108 pushed a commit to rancher/kubernetes that referenced this pull request May 20, 2016
…deployment-example

Auto commit by PR queue bot
(cherry picked from commit 2c5903a)
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…deployment-example

Auto commit by PR queue bot
(cherry picked from commit 2c5903a)
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…deployment-example

Auto commit by PR queue bot
(cherry picked from commit 2c5903a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants