-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions/replicaset to federation-apiserver #24764
Add extensions/replicaset to federation-apiserver #24764
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
@nikhiljindal PTAL |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
what's the plan of this PR's merge? the federation scheduler depends on this PR. |
@@ -285,3 +289,28 @@ func testCoreResourceList(t *testing.T) { | |||
assert.NotNil(t, found) | |||
assert.True(t, found.Namespaced) | |||
} | |||
func testExtensionsResourceList(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a line break above this function
@@ -23,13 +23,15 @@ import ( | |||
"encoding/json" | |||
"fmt" | |||
"io/ioutil" | |||
fed_v1b1 "k8s.io/kubernetes/federation/apis/federation/v1beta1" | |||
//"k8s.io/kubernetes/federation/cmd/federated-apiserver/app/options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
@k8s-bot ok to test. A few minor nits, mostly LGTM |
comments fixed and rebased |
GCE e2e build/test passed for commit bf3e1a5. |
LGTM, thanks! Next, you will need to update the federation client set to include extensions group version. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit bf3e1a5. |
Automatic merge from submit-queue |
…ns-replicaset-client Automatic merge from submit-queue Generate federation apiserver extensions replicaset client generate clientset for extensions/ReplicaSet of federation apiserver @nikhiljindal @quinton-hoole, @deepak-vij #24764
Add extensions/replicaset for federated scheduler (#24038) as all k8s api objects were removed in #23959
Please review only the very last one commit.
#19313 #23653
@nikhiljindal @quinton-hoole, @deepak-vij, @XiaoningDing, @alfred-huangjian @mfanjie @huangyuqi @colhom