Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container-port flag is deprecated #25072

Merged
merged 1 commit into from
May 6, 2016
Merged

Container-port flag is deprecated #25072

merged 1 commit into from
May 6, 2016

Conversation

adohe-zz
Copy link

@adohe-zz adohe-zz commented May 3, 2016 •
edited
Loading

Refer #25039 for more detail. @Kargakis ptal. Also in this PR just mark this flag as deprecated, we should also remove the code in the future.

@k8s-github-robot k8s-github-robot added kind/old-docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2016
@0xmichalis
Copy link
Contributor

LGTM

@smarterclayton @bgrant0607 WDYT?

@k8s-github-robot
Copy link

@adohe
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@adohe-zz
Copy link
Author

adohe-zz commented May 3, 2016

@k8s-bot test this issue: #23974

@smarterclayton
Copy link
Contributor

LGTM

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2016
luxas
luxas reviewed May 3, 2016
View reviewed changes
CHANGELOG.md
@@ -2,6 +2,7 @@

- [v1.3.0-alpha.3](#v130-alpha3)
- [Downloads](#downloads)
- [v1.3.0-alpha.3](#v130-alpha3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this added?

@luxas
Copy link
Member

luxas commented May 3, 2016

Is the policy to add release-note to deprecations? I think we should do that.

@luxas luxas added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 4, 2016
@luxas
Copy link
Member

luxas commented May 4, 2016

Okay, it's worthy a release note as it changes the ux. cc/ @david-mcmahon
Is it okay if I'm adding back lgtm, given the multiple ones already?

@bgrant0607 bgrant0607 added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 4, 2016
@bgrant0607
Copy link
Member

Thanks, LGTM.

Deprecations belong in the "action required" section of the release notes. I updated that label.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@k8s-bot
Copy link

k8s-bot commented May 6, 2016

GCE e2e build/test passed for commit ba69f0f.

@roberthbailey roberthbailey merged commit bb08b27 into kubernetes:master May 6, 2016
@adohe-zz adohe-zz deleted the deprecate_container_port branch May 7, 2016 08:27
@erictune erictune mentioned this pull request Jul 2, 2016
Closed
@erictune erictune changed the title mark container-port flag as deprecated Container-port flag is deprecated Jul 2, 2016
@WanLinghao WanLinghao mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@adohe-zz @0xmichalis @k8s-github-robot @smarterclayton @luxas @bgrant0607 @k8s-bot @googlebot @roberthbailey @adohe