-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple APIs to register for the same API Group #28414
Conversation
@brendandburns do you want to cherry pick this into the 1.3 branch? |
are you able to build this? I'm seeing errors such as:
but to be honest it might be my env. |
@caesarxuchao thanks! |
@lavalamp @caesarxuchao can I get a quick review on this? Thanks |
Thanks @brendandburns. LGTM. |
GCE e2e build/test passed for commit ca9a61b. |
Automatic merge from submit-queue |
This does not seem to fix the issue. Tested at ed3a29b
|
}, | ||
}, | ||
} | ||
err := master.InstallThirdPartyResource(api) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unit test doesn't equal to real cases.
See here:
hasResource, err := t.master.HasThirdPartyResource(rsrc)
if !hasResource {
return t.master.InstallThirdPartyResource(rsrc)
}
The bug was caused in HasThirdPartyResource
returning true because the API Group has been registered before despite of different resource kind.
I tried to fix it by comparing both API group and resource kind. But I got error:
[restful] WebService with duplicate root path detected:
Seems like rest path duplicate reg. Any suggestion on how to handle the install rest thing? @brendandburns
@polvi let me try to repro this again. I did exactly the above with my branch... |
The same thing is happening on c7ec11b |
Automatic merge from submit-queue Fix third party APIResource reporting @polvi @caesarxuchao @deads2k This "fixes" some additional bugs in third party `APIResourceList` reporting. This code needs a bunch of cleanup, and more tests, but sending it out for a quick smell check review in case I'm doing something stupid. Fixes the bug referenced here: #28414 (comment) and in #23831 Fixes #25570
@brendandburns @pwittrock This is in v1.4 milestone, but with cherrypick tags. Is the intent still to get into 1.3.x at some point? |
This already went into 1.4. Removing cherrypick tags. |
Fixes #23831
@kubernetes/sig-api-machinery
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)