Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-up: install new Docker pre-requisite (libltdl7) when not in image #28745

Merged
merged 1 commit into from
Jul 13, 2016
Merged

kube-up: install new Docker pre-requisite (libltdl7) when not in image #28745

merged 1 commit into from
Jul 13, 2016

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jul 10, 2016 •
edited by k8s-oncall

Docker now has a dependency on libltdl7; we have to specify it manually
if we are installing docker using dpkg (vs using apt-get or similar,
which would pull it in automatically)

Fixes #28644

This change is Reviewable

@justinsb
kube-up: install libltdl7 when installing docker with dpkg
4bde831 
Docker now has a dependency on libltdl7; we have to specify it manually
if we are installing docker using dpkg (vs using apt-get or similar,
which would pull it in automatically)

Fixes kubernetes#28644
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 11, 2016
@k8s-bot
Copy link

k8s-bot commented Jul 11, 2016

GCE e2e build/test passed for commit 4bde831.

@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 11, 2016
@justinsb justinsb changed the title kube-up: install libltdl7 when installing docker with dpkg kube-up: install new Docker pre-requisite (libltdl7) when not in image Jul 11, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@justinsb
Copy link
Member Author

This is pretty important @roberthbailey - kube-up with 1.3 is broken on wily because of it...

@roberthbailey
Copy link
Contributor

Sorry... falling behind on my code reviews. :/

@roberthbailey
Copy link
Contributor

@zmerlynn - can you verify that this is a no-op on GCE/GKE?

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2016
@zmerlynn
Copy link
Member

Looks fine, yeah.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jul 13, 2016

GCE e2e build/test passed for commit 4bde831.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2906a35 into kubernetes:master Jul 13, 2016
@roberthbailey
Copy link
Contributor

@justinsb does this need a cherry pick into 1.3?

@roberthbailey roberthbailey added this to the v1.3 milestone Jul 13, 2016
@fabioy
Copy link
Contributor

fabioy commented Jul 19, 2016

@justinsb Please let me know if you want this to be cherrypicked into 1.3 (and create a cherrypick PR). Thanks.

@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 18, 2016
@fabioy fabioy removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Sep 12, 2016
@fabioy
Copy link
Contributor

fabioy commented Sep 12, 2016

Removing cherrypick label due to no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

@roberthbailey roberthbailey

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@justinsb @k8s-bot @k8s-cherrypick-bot @roberthbailey @zmerlynn @k8s-github-robot @fabioy @googlebot