Increase the AppArmor pod stop timeout to match the start timeout #31314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timstclair
added
priority/critical-urgent
k8s-github-robot
added
the
size/XS
|
LGTM |
dchen1107
added
the
lgtm
| @@ -146,7 +146,9 @@ func loadTestProfiles() error { | |||
|
|
|||
| func runAppArmorTest(f *framework.Framework, profile string) api.PodStatus { | |||
| pod := createPodWithAppArmor(f, profile) | |||
| framework.ExpectNoError(f.WaitForPodNoLongerRunning(pod.Name)) | |||
| // The pod needs to start before it stops, so wait for the longer start timeout. | |||
There was a problem hiding this comment.
Just for my own education, all apparmor tests expect the pod to fail in certain way?
There was a problem hiding this comment.
not necessarily fail. The pod container just runs touch and exits, and then the apparmor tests look at the container exit code to determine whether it succeeded (which should be conditional on whether the profile was applied correctly)
There was a problem hiding this comment.
I see. So the test expects the pod to terminate soon. Thanks for answering!
|
GCE e2e build/test passed for commit a29ad35. |
|
Automatic merge from submit-queue |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30750
This change is