-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GlusterFS provisioning readme with endpoint/service details #31854
Update GlusterFS provisioning readme with endpoint/service details #31854
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
5 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
@rootfs PTAL at this PR |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
2 similar comments
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
@zmerlynn this PR is an update in provisioning readme to provide more details to user wrt the glusterfs DP configuration. Please have a look at the same. Thanks! |
glusterfs-cluster 10.240.106.152:1,10.240.79.157:1 | ||
``` | ||
|
||
We need also create a service for this endpoints, so that the endpoints will be persisted. We will add this service without a selector to tell Kubernetes we want to add its endpoints manually.You can see [glusterfs-service.json](examples/volumes/glusterfs/glusterfs-service.json)for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to glusterfs-server.json
is not correct. You have to go to the top of examples
directory first.
@kubernetes/sig-storage |
d1dc6c9
to
1577e0d
Compare
@rootfs any thoughts why most of the tests are not running on this PR? |
@k8s-bot ok to test |
ok to test |
1577e0d
to
a692c13
Compare
|
66252ca
to
fab12e5
Compare
fab12e5
to
377c7c1
Compare
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
377c7c1
to
a601e8a
Compare
GCE e2e build/test passed for commit a601e8a. |
Automatic merge from submit-queue |
Should be in the 1.4.x branch: #33009 |
cherry-picked in #34766 |
…ck-of-#31854-kubernetes#32198-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#31854 kubernetes#32198 origin release 1.4 Cherry pick of kubernetes#31854 kubernetes#32198 on release-1.4. kubernetes#31854: Update glusterfs provisioner readme with endpoint/service kubernetes#32198: fixup storage examples
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)