-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle DeletedFinalStateUnknown in NodeController #34694
Handle DeletedFinalStateUnknown in NodeController #34694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably open an issue to go through the code and check we don't have the same problem in other places. @lavalamp - FYI
if !isNode { | ||
deletedState, ok := obj.(cache.DeletedFinalStateUnknown) | ||
if !ok { | ||
glog.Warningf("Received unexpected object: %v", obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errorf (if we don't get neither node nor deletedfinalstateunknown, then we really have problem)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
} | ||
node, ok = deletedState.Obj.(*api.Node) | ||
if !ok { | ||
glog.Warningf("DeletedFinalStateUnknown contained non-Node object: %v", deletedState.Obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errorf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
29599a8
to
8b7e9d3
Compare
@gmarek - this PR probably requires release-note, as well as should probably be cherrrypicked |
Agreed |
/lgtm |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Oops, sorry I missed this when I did #34786. Thanks for catching it. |
…-of-#34694-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#34694 Cherry pick of kubernetes#34694 on release-1.4. kubernetes#34694: Handle DeletedFinalStateUnknown in NodeController
Fix #34692
cc @davidopp
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)