Handle DeletedFinalStateUnknown in NodeController #34694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
reviewed
Oct 13, 2016
| if !isNode { | ||
| deletedState, ok := obj.(cache.DeletedFinalStateUnknown) | ||
| if !ok { | ||
| glog.Warningf("Received unexpected object: %v", obj) |
There was a problem hiding this comment.
Errorf (if we don't get neither node nor deletedfinalstateunknown, then we really have problem)
| } | ||
| node, ok = deletedState.Obj.(*api.Node) | ||
| if !ok { | ||
| glog.Warningf("DeletedFinalStateUnknown contained non-Node object: %v", deletedState.Obj) |
gmarek
force-pushed
the
deleted_final_state_unknown
branch
from
29599a8
to
8b7e9d3
Compare
|
@gmarek - this PR probably requires release-note, as well as should probably be cherrrypicked |
gmarek
added
release-note
|
Agreed |
k8s-github-robot
added
the
size/S
|
/lgtm |
k8s-github-robot
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
jessfraz
added
the
cherry-pick-approved
|
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
|
Oops, sorry I missed this when I did #34786. Thanks for catching it. |
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-of-#34694-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#34694 Cherry pick of kubernetes#34694 on release-1.4. kubernetes#34694: Handle DeletedFinalStateUnknown in NodeController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34692
cc @davidopp
This change is