-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere Kube-up: resolve vm-names on all nodes. #35365
vSphere Kube-up: resolve vm-names on all nodes. #35365
Conversation
vm-names are used for vSphere cloud provider and they need to resolution for log collection to work.
Other than the issue being fixed there is no need for release-node-label-needed. |
Do we do this on any other cloud providers? Or do we just expect that to be part of the infrastructure for things like GCE and AWS? |
A lot of other deployments use IP address directly when nodes connect to master(using host override), the current implementation of vSphere Cloud Provider needs vm-names and we need this PR to resolve the vm-names to ip when dashboard retrieves logs. Since kube-up is designed to be deployed on any kind of vSphere deployment, the VM ip addresses are discovered and the mapping information needs to be propagated. Without this PR in 1.4 branch and master, any communication that is node to node fails and it includes getting logs in dashboard. This is not the same as pod to pod communication. We are looking into changing how vSphere Cloud Provider manages vm-names and IPs and how we setup the nodes (support for kube-anywhere) but those changes will be further down the road and aimed at 1.5. |
Automatic merge from submit-queue |
…-of-#35365-upstream-release-1.4 Automatic merge from submit-queue vSphere Kube-up: resolve vm-names on all nodes. Automated cherry-pick of kubernetes#35365 fixes kubernetes#35364
What this PR does / why we need it:
This addresses the #35364
Which issue this PR fixes (optional, in
fixes #<issue number>(, #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #35364
Special notes for your reviewer:
Will cherry pick to release-1.4
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)