Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation] Expose autoscaling apis through federation api server #38976

Merged
merged 3 commits into from
Jan 23, 2017
Merged

[Federation] Expose autoscaling apis through federation api server #38976

merged 3 commits into from
Jan 23, 2017

Conversation

irfanurrehman
Copy link
Contributor

This PR implements first part of federated pod autoscaler.
The issue to handle the whole feature is #38974

cc @kubernetes/sig-cluster-federation
@shashidharatd @kshafiee @deepak-vij

Release note:

federation users can now use federated autoscaling resources and create federated horizontalpodautoscalers

@k8s-ci-robot
Copy link
Contributor

Hi @irfanurrehman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 19, 2016
@irfanurrehman irfanurrehman mentioned this pull request Dec 19, 2016
Closed
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2017
@ghost
Copy link

ghost commented Jan 10, 2017

@k8s-bot ok to test

@ghost
Copy link

ghost commented Jan 10, 2017

@mwielgus can you take this one?

@ghost ghost assigned mwielgus and unassigned ghost Jan 10, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit d88d5042879e70047f2096c3b23fc645b97e9a6e. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit d88d5042879e70047f2096c3b23fc645b97e9a6e. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d88d5042879e70047f2096c3b23fc645b97e9a6e. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mwielgus
Copy link
Contributor

@irfanurrehman - the code is mostly auto-generated, right? If yes then please do the rebase and get the tests green and I will LGTM it.

@mwielgus mwielgus self-requested a review January 18, 2017 23:02
@irfanurrehman
Copy link
Contributor Author

@mwielgus , yes you are right this one is mostly generated code.
I did rebase it yesterday night, and tests pass in my local env.
But not sure, why they are failing here. The logs don't look relavant to my portion of code at all.
Trying to figure out why they are failing here.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit d923c10cfe4618dfbec028506b653cbc50bb50a9. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irfanurrehman
Copy link
Contributor Author

@k8s-bot test this

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 4045de96d07504a2c341f64e50415685eba550bb. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 4045de96d07504a2c341f64e50415685eba550bb. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irfanurrehman
Copy link
Contributor Author

@k8s-bot gce etcd3 e2e test this

@irfanurrehman
Copy link
Contributor Author

@k8s-bot gci gce e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit 4045de96d07504a2c341f64e50415685eba550bb. Full PR test history. cc @irfanurrehman

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irfanurrehman irfanurrehman mentioned this pull request Jan 19, 2017
Closed
@irfanurrehman
Copy link
Contributor Author

@k8s-bot cri node e2e test this

@irfanurrehman
Copy link
Contributor Author

@mwielgus all tests pass as of now. Some tests seem flake to me, failures vanish if I rerun them (but not sure how to address them).
Also, it will be amazingly kind, if you can review this next PR in chain (mostly autogenerated code) #40158
and take a quick look at the actual controller code and give your comments here #40158

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2017
@irfanurrehman
Copy link
Contributor Author

irfanurrehman commented Jan 22, 2017 •
edited
Loading

@mwielgus PTAL!, I have rebased it couple of times already.
Thanks.

@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2017
@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added this to the 1.6 milestone Jan 22, 2017
@irfanurrehman
Copy link
Contributor Author

@mwielgus, I think you need to close the review also, to get this automatically merged.
thanks again!

@mwielgus
Copy link
Contributor

No, you are in the merge queue but at position +10. So it will take a while.

@irfanurrehman
Copy link
Contributor Author

@mwielgus
got it. Thanks for correcting my understanding!
It will be great if you can have a quick glance and give some suggestions for #40162 also.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 79c0001 into kubernetes:master Jan 23, 2017
@calebamiles calebamiles modified the milestones: v1.6, 1.6 Feb 13, 2017
@irfanurrehman irfanurrehman mentioned this pull request Jul 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@mwielgus mwielgus

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@irfanurrehman @k8s-ci-robot @k8s-reviewable @mwielgus @k8s-github-robot @calebamiles