-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'all namespaces' meaning of empty list in PodAffinityTerm #43271
Remove 'all namespaces' meaning of empty list in PodAffinityTerm #43271
Conversation
@davidopp @aveshagarwal PTAL |
I hadn't seen you PR, so sent out #43278 to add the "*" behavior. (But see the comment about my build environment being messed up so couldn't run hack/update-all.sh or test it.) I think it's slightly better if we can do the "*" at the same time as changing the nil/empty behavior, but if nobody has time to pick up that PR then I'm OK with this one. |
@liggitt thanks lgtm. |
@davidopp -- i would like @kubernetes/sig-scheduling-misc to start thinking about a |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davidopp, liggitt
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
I'm marking this "release-note-none" and going to update the manual release notes to mention this. |
@k8s-bot verify test this |
Automatic merge from submit-queue (batch tested with PRs 43313, 43257, 43271, 43307) |
Removes the distinction between
null
and[]
for the PodAffinityTerm#namespaces field (option 4 discussed in #43203 (comment)), since we can't distinguish between them in protobuf (and it's a less than ideal API)Leaves the door open to reintroducing "all namespaces" function via a dedicated field or a dedicated token in the list of namespaces
Wanted to get a PR open and tests green in case we went with this option.
Not sure what doc/release-note is needed if the "all namespaces" function is not present in 1.6