Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'all namespaces' meaning of empty list in PodAffinityTerm #43271

Merged
merged 3 commits into from
Mar 17, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 17, 2017

Removes the distinction between null and [] for the PodAffinityTerm#namespaces field (option 4 discussed in #43203 (comment)), since we can't distinguish between them in protobuf (and it's a less than ideal API)

Leaves the door open to reintroducing "all namespaces" function via a dedicated field or a dedicated token in the list of namespaces

Wanted to get a PR open and tests green in case we went with this option.

Not sure what doc/release-note is needed if the "all namespaces" function is not present in 1.6

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2017
@liggitt liggitt assigned aveshagarwal and davidopp and unassigned erictune Mar 17, 2017
@liggitt
Copy link
Member Author

liggitt commented Mar 17, 2017

@davidopp @aveshagarwal PTAL
cc @kubernetes/sig-scheduling-misc

@liggitt liggitt added this to the v1.6 milestone Mar 17, 2017
@davidopp
Copy link
Member

I hadn't seen you PR, so sent out #43278 to add the "*" behavior. (But see the comment about my build environment being messed up so couldn't run hack/update-all.sh or test it.)

I think it's slightly better if we can do the "*" at the same time as changing the nil/empty behavior, but if nobody has time to pick up that PR then I'm OK with this one.

@aveshagarwal
Copy link
Member

@liggitt thanks lgtm.

@derekwaynecarr
Copy link
Member

@davidopp -- i would like @kubernetes/sig-scheduling-misc to start thinking about a PodSchedulingPolicy object that I could use to provide more granular control where its needed. So if I do not want to let pods in namespace A stalk pods in namespace B, I should be able to control that via policy. For example, I do not want to let users stalk any of the kube-system components (scheduler, etc.) unless I entitle them to do that action.

@davidopp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 17, 2017
@davidopp
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidopp, liggitt
We suggest the following additional approver: @lavalamp

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@davidopp davidopp added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 17, 2017
@davidopp
Copy link
Member

I'm marking this "release-note-none" and going to update the manual release notes to mention this.

@davidopp davidopp added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 17, 2017
@davidopp
Copy link
Member

@k8s-bot verify test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43313, 43257, 43271, 43307)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants