Automated cherry pick of #41929 #42974 upstream release 1.6

[BaluDontu]

Cherry pick of #41929 #42974 on release-1.6.

#41929: vSphere Cloud Provider: Fstype in storage class
#42974: VSAN policy support for storage volume provisioning inside kubernetes

@saad-ali

[k8s-ci-robot]

Hi @BaluDontu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-reviewable]

This change is 

[BaluDontu]

@saad-ali : Can you please take a look at this PR. I didn't have the cherry-pick label on this PR. Can you add one.

[luomiao]

/approve

[abrarshivani]

/approve

[enisoc]

@BaluDontu On the surface, this looks like it adds a new capability, which is not allowed in patch releases. If this is somehow needed to fix a bug, please explain or link to context that shows the severity of the issue.

[BaluDontu]

@enisoc : Yes its a new capability. The problem is right now we only limit our users to create persistent volumes of a single file system type. This is too narrow for us and a very basic functionality from us.
Allowing users to have create a persistent volume of multiple file system types and configuring it with a VSAN policy is a big ask from our customers as most of our kubernetes deployment on vSphere are on VSAN platform.

The point is that we just missed the 1.6 release cut by a few days. Isn't possible to have these included as part of patch releases ? Otherwise we would have wait next 1.7 release for these features which would be too late for us.

[enisoc]

@saad-ali @childsb Could one of you weigh in on behalf of sig-storage? Is this change appropriate for a patch release?

[BaluDontu]

@saad-ali @childsb : Any updates on this one?

[saad-ali]

@enisoc By the strictly definition of a patch release, since this introduces new functionality, it does not qualify:

Patch releases are intended for critical bug fixes to the latest minor version, such as addressing security vulnerabilities, fixes to problems affecting a large number of users, severe problems with no workaround, and blockers for products based on Kubernetes.

They should not contain miscellaneous feature additions or improvements, and especially no incompatibilities should be introduced between patch versions of the same minor version (or even major version).

That said it is isolated to the VSphere volume plugin and the changes appear to be backwards compatible, so I would be ok granting an exception. Final call is yours.

[enisoc]

@saad-ali Thanks. I will go with your recommendation since it's in the storage area.

@k8s-bot ok to test

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BaluDontu, abrarshivani, enisoc, luomiao
We suggest the following additional approver: @thockin

Needs approval from an approver in each of these OWNERS Files:

• examples/OWNERS
• pkg/cloudprovider/providers/vsphere/OWNERS [abrarshivani,luomiao]
• pkg/volume/OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[BaluDontu]

@enisoc : Can you rerun the test - @k8s-bot cvm gce e2e test this?

[enisoc]

It looks like you have the power. :)

[k8s-github-robot]

Automatic merge from submit-queue