-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #41929 #42974 upstream release 1.6 #44375
Automated cherry pick of #41929 #42974 upstream release 1.6 #44375
Conversation
Hi @BaluDontu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@saad-ali : Can you please take a look at this PR. I didn't have the cherry-pick label on this PR. Can you add one. |
/approve |
/approve |
@BaluDontu On the surface, this looks like it adds a new capability, which is not allowed in patch releases. If this is somehow needed to fix a bug, please explain or link to context that shows the severity of the issue. |
@enisoc : Yes its a new capability. The problem is right now we only limit our users to create persistent volumes of a single file system type. This is too narrow for us and a very basic functionality from us. The point is that we just missed the 1.6 release cut by a few days. Isn't possible to have these included as part of patch releases ? Otherwise we would have wait next 1.7 release for these features which would be too late for us. |
@enisoc By the strictly definition of a patch release, since this introduces new functionality, it does not qualify:
That said it is isolated to the VSphere volume plugin and the changes appear to be backwards compatible, so I would be ok granting an exception. Final call is yours. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BaluDontu, abrarshivani, enisoc, luomiao
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
It looks like you have the power. :) |
Automatic merge from submit-queue |
Cherry pick of #41929 #42974 on release-1.6.
#41929: vSphere Cloud Provider: Fstype in storage class
#42974: VSAN policy support for storage volume provisioning inside kubernetes
@saad-ali