Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up npd version to v0.4.0 #46743

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Bump up npd version to v0.4.0 #46743

merged 1 commit into from
Jun 8, 2017

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jun 1, 2017 •
edited
Loading

Fixes #47070.

Bump up npd version to v0.4.0.

Bump up Node Problem Detector version to v0.4.0, which added support of parsing log from /dev/kmsg and ABRT.

/cc @dchen1107 @ajitak

@Random-Liu Random-Liu added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 1, 2017
@Random-Liu Random-Liu added this to the v1.7 milestone Jun 1, 2017
@k8s-ci-robot k8s-ci-robot requested review from ajitak and dchen1107 June 1, 2017 00:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2017
@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2017
@ajitak
Copy link
Contributor

ajitak commented Jun 1, 2017

This will result in merge conflict with #46524

@Random-Liu
Copy link
Member Author

Will rebase after #46524 is merged.

@ajitak
Copy link
Contributor

ajitak commented Jun 1, 2017 •
edited
Loading

Is it possible to declare NPD version in one file and use it everywhere? That way only one file requires update for any subsequent version bump.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jun 6, 2017

@Random-Liu - if you want this for 1.7, can you please rebase and add an issue to the description?

@Random-Liu
Copy link
Member Author

@wojtek-t Sure. Will do now.

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 6, 2017
@Random-Liu
Copy link
Member Author

Only did a rebase, reapply lgtm.

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2017
@Random-Liu
Copy link
Member Author

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2017
@Random-Liu
Copy link
Member Author

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 7, 2017 •
edited
Loading

@Random-Liu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 04cefe5667c07064fe563c0caf4dbc62bfaa386b link @k8s-bot pull-kubernetes-federation-e2e-gce test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Random-Liu
Copy link
Member Author

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@ajitak
Copy link
Contributor

ajitak commented Jun 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, ajitak, dchen1107

Associated issue: 47070

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9c1b2aa into kubernetes:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitak ajitak Awaiting requested review from ajitak

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@ajitak ajitak

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Random-Liu @dchen1107 @ajitak @wojtek-t @k8s-ci-robot @k8s-github-robot