Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename stop.go to delete.go to avoid confusion #49533

Merged
merged 1 commit into from
Jul 30, 2017
Merged

rename stop.go to delete.go to avoid confusion #49533

merged 1 commit into from
Jul 30, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 25, 2017 •
edited

What this PR does / why we need it:

Refer to comments from @foxish and @janetkuo

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
xref #46784

Special notes for your reviewer:

/cc @janetkuo @foxish

Release note:

rename stop.go file to delete.go to avoid confusion

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 25, 2017
@foxish
Copy link
Contributor

foxish commented Jul 25, 2017

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2017
@foxish
Copy link
Contributor

foxish commented Jul 25, 2017

cc/ @kubernetes/sig-cli-pr-reviews for approval.

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jul 25, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

/retest

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2017
@shiywang
Copy link
Contributor

LGTM, thanks for renaming it, could you also squash your commits ?

@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

@shiywang Updated. PTAL. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

/test pull-kubernetes-kubemark-e2e-gce

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 26, 2017

@janetkuo @foxish PTAL. Needs your /lgtm and /approval. Thanks.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 29, 2017

@adohe @derekwaynecarr @janetkuo @foxish Rebased. PTAL. Thanks.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 29, 2017

/test pull-kubernetes-e2e-kops-aws

@dixudx
Copy link
Member Author

dixudx commented Jul 29, 2017

/test pull-kubernetes-bazel

1 similar comment
@dixudx
Copy link
Member Author

dixudx commented Jul 30, 2017

/test pull-kubernetes-bazel

@adohe-zz
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, dixudx, foxish

Associated issue: 46784

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2017
@adohe-zz
Copy link

/approval

@adohe-zz
Copy link

/test pull-kubernetes-bazel

@dixudx
Copy link
Member Author

dixudx commented Jul 30, 2017

Test failure is due to #49844.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@dixudx
Copy link
Member Author

dixudx commented Jul 30, 2017

/retest

@dixudx
Copy link
Member Author

dixudx commented Jul 30, 2017

/test pull-kubernetes-e2e-gce-etcd3

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@dixudx: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws ac6ec1a link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-federation-e2e-gce ac6ec1a link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-e2e-gce-etcd3 ac6ec1a link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49533, 49264)

@k8s-github-robot k8s-github-robot merged commit cd44d1d into kubernetes:master Jul 30, 2017
@dixudx dixudx deleted the rename_stop_to_delete branch July 31, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxish foxish Awaiting requested review from foxish

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@foxish foxish

@adohe-zz adohe-zz

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dixudx @k8s-ci-robot @foxish @shiywang @adohe-zz @k8s-github-robot @fejta-bot @derekwaynecarr