Added field CollisionCount to StatefulSetStatus #49983

liyinan926 · 2017-08-01T21:08:10Z

What this PR does / why we need it:
This PR added a new field CollisionCount into StatefulSetStatus, similarly in terms of both name and semantics to the existing CollisionCount field in DaemonSetStatus. The field will be used for collision avoidance when the StatefulSet controller creates name for the newest ControllerRevision, which will be done in another PR.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): #49909.

Special notes for your reviewer:
A second PR will include logic that actually uses the field for collision avoidance.

Release note:

Added field CollisionCount to StatefulSetStatus in both apps/v1beta1 and apps/v1beta2

k8s-ci-robot · 2017-08-01T21:08:12Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-08-01T21:08:17Z

Hi @liyinan926. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

liyinan926 · 2017-08-01T21:17:10Z

CLA signed.

supereagle · 2017-08-02T08:03:51Z

pkg/apis/apps/types.go

@@ -187,6 +187,12 @@ type StatefulSetStatus struct {
 	// updateRevision, if not empty, indicates the version of the StatefulSet used to generate Pods in the sequence
 	// [replicas-updatedReplicas,replicas)
 	UpdateRevision string
+
+	// Count of hash collisions for the StatefulSet. The StatefulSet controller


Please keep the code style, like "collisionCount is the count of hash collisions for the StatefulSet ..."
Please also fix the code style in other places for this field.

kow3ns · 2017-08-02T18:24:45Z

/ok-to-test

k8s-ci-robot · 2017-08-02T21:58:39Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

liyinan926 · 2017-08-02T22:33:06Z

/retest

liyinan926 · 2017-08-05T04:22:54Z

/assign @thockin

liyinan926 · 2017-08-07T16:48:04Z

/assign thockin

liyinan926 · 2017-08-07T23:07:39Z

@thockin Need your approval. PTAL. Thanks!

thockin · 2017-08-07T23:22:53Z

pkg/apis/apps/types.go

+	// uses this field as a collision avoidance mechanism when it needs to create the name for the
+	// newest ControllerRevision.
+	// +optional
+	CollisionCount *int64


Why is this int64 and not int32? Do you expect more than 2 billion collisions? JSON is known to have trouble carrying int64 values, which can make automated API fuzzing difficult.

This is for consistency across controllers. It's the type of the field used by other controllers, e.g., here and here.

Consistent with wrong is still wrong. I'd like to hear a reason this can't be int32, and the others fixed.

Will update to use int32 and have a follow up PR to change it to int32 in other controllers.

@thockin

JSON is known to have trouble carrying int64 values, which can make automated API fuzzing difficult.

This is not an issue that users have actually reported having, and fuzzing currently works for these API objects. If you configure your decoder appropriately or use structs, or classes depending on the language, to decode, disambiguating int64 values is definitely achievable without much work.

Given that the API for Deployment and DeamonSet both went through community design review prior to implementation and merge, that there is no measurable performance benefit to using an int32 in this case, that we use int64 in many other places in the API, and that we don't have an actual issue to motivate changing all the workloads API objects, I don't see why we should switch this field to int32.

@thockin What are your thoughts on the comment @kow3ns made above?

Discussed. We should convert to int32 in bulk.

SGTM. Will have a PR to convert all.

liyinan926 · 2017-08-08T14:33:17Z

/test pull-kubernetes-unit

liyinan926 · 2017-08-08T18:10:11Z

@thockin replied to your comment. PTAL. Thanks!

liyinan926 · 2017-08-09T16:16:03Z

@kow3ns need lgtm again after rebasing. @thockin need you approval. PTAL. Thanks!

kow3ns · 2017-08-09T17:03:20Z

/retest

kow3ns · 2017-08-09T17:03:45Z

/lgtm

liyinan926 · 2017-08-09T17:43:48Z

/retest

thockin · 2017-08-10T19:57:21Z

/approve

k8s-github-robot · 2017-08-10T19:57:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kow3ns, liyinan926, thockin

Associated issue: 49909

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~api/OWNERS~~ [thockin]
~~docs/OWNERS~~ [thockin]
~~pkg/api/OWNERS~~ [thockin]
~~staging/src/k8s.io/api/OWNERS~~ [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-11T01:45:52Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-11T02:35:14Z

Automatic merge from submit-queue

caesarxuchao · 2017-08-22T06:09:20Z

@liyinan926 do you remember why the PR had two merge commits "Merge branch 'master' of github.com:kubernetes/kubernetes"? Did you merge your local branch with kubernetes/kubernetes master branch before submitting the PR?

@sttts reported this PR broke the publishing robot because the robot skipped merge commits while in case of this PR, the merge commits are non-empty.

liyinan926 · 2017-08-22T06:23:52Z

@caesarxuchao @sttts I don't remember exactly why but I did pulled the master branch and rebased before the PR was approved and submitted.

Automatic merge from submit-queue Added field CollisionCount to StatefulSetStatus **What this PR does / why we need it**: This PR added a new field `CollisionCount` into `StatefulSetStatus`, similarly in terms of both name and semantics to the existing `CollisionCount` field in `DaemonSetStatus`. The field will be used for collision avoidance when the `StatefulSet` controller creates name for the newest ControllerRevision, which will be done in another PR. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: kubernetes#49909. **Special notes for your reviewer**: A second PR will include logic that actually uses the field for collision avoidance. **Release note**: ```release-note Added field CollisionCount to StatefulSetStatus in both apps/v1beta1 and apps/v1beta2 ```

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2017

k8s-github-robot assigned caesarxuchao and david-mcmahon Aug 1, 2017

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Aug 1, 2017

david-mcmahon removed their assignment Aug 1, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 1, 2017

supereagle reviewed Aug 2, 2017

View reviewed changes

liyinan926 force-pushed the master branch from 6e4b647 to f1cb748 Compare August 2, 2017 13:57

k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 2, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2017

liyinan926 force-pushed the master branch from b8ce6ac to a20446d Compare August 2, 2017 20:37

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 2, 2017

liyinan926 force-pushed the master branch from a20446d to 0a8c9f7 Compare August 2, 2017 21:58

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2017

liyinan926 force-pushed the master branch from 0a8c9f7 to eb2d078 Compare August 2, 2017 22:32

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 2, 2017

k8s-ci-robot assigned thockin Aug 5, 2017

liyinan926 mentioned this pull request Aug 5, 2017

Change default update strategy to rolling update #50175

Merged

thockin reviewed Aug 7, 2017

View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2017

liyinan926 added 2 commits August 9, 2017 08:44

Added changes as a result of running make update

f4d5963

Merge branch 'master' of github.com:kubernetes/kubernetes

7ec391e

liyinan926 force-pushed the master branch from e629a19 to 7ec391e Compare August 9, 2017 16:14

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 9, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2017

k8s-github-robot merged commit d72ffcd into kubernetes:master Aug 11, 2017

zhouhaibing089 mentioned this pull request Aug 11, 2017

add fuzzer dir for each apigroup #50130

Merged

liyinan926 mentioned this pull request Aug 11, 2017

CollisionCount should have type int32 instead of int64 in all relevant controllers #50530

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added field CollisionCount to StatefulSetStatus #49983

Added field CollisionCount to StatefulSetStatus #49983

liyinan926 commented Aug 1, 2017 •

edited

Loading

k8s-ci-robot commented Aug 1, 2017

k8s-ci-robot commented Aug 1, 2017

liyinan926 commented Aug 1, 2017

supereagle Aug 2, 2017

liyinan926 Aug 2, 2017

kow3ns commented Aug 2, 2017

k8s-ci-robot commented Aug 2, 2017

liyinan926 commented Aug 2, 2017

liyinan926 commented Aug 5, 2017

liyinan926 commented Aug 7, 2017

liyinan926 commented Aug 7, 2017

thockin Aug 7, 2017

liyinan926 Aug 7, 2017 •

edited

Loading

thockin Aug 9, 2017

liyinan926 Aug 9, 2017

kow3ns Aug 9, 2017

liyinan926 Aug 10, 2017

thockin Aug 10, 2017

liyinan926 Aug 10, 2017

liyinan926 commented Aug 8, 2017

liyinan926 commented Aug 8, 2017

liyinan926 commented Aug 9, 2017

kow3ns commented Aug 9, 2017

kow3ns commented Aug 9, 2017

liyinan926 commented Aug 9, 2017

thockin commented Aug 10, 2017

k8s-github-robot commented Aug 10, 2017

k8s-github-robot commented Aug 11, 2017

k8s-github-robot commented Aug 11, 2017

caesarxuchao commented Aug 22, 2017

liyinan926 commented Aug 22, 2017

Added field CollisionCount to StatefulSetStatus #49983

Added field CollisionCount to StatefulSetStatus #49983

Conversation

liyinan926 commented Aug 1, 2017 • edited Loading

k8s-ci-robot commented Aug 1, 2017

k8s-ci-robot commented Aug 1, 2017

liyinan926 commented Aug 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kow3ns commented Aug 2, 2017

k8s-ci-robot commented Aug 2, 2017

liyinan926 commented Aug 2, 2017

liyinan926 commented Aug 5, 2017

liyinan926 commented Aug 7, 2017

liyinan926 commented Aug 7, 2017

Choose a reason for hiding this comment

liyinan926 Aug 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liyinan926 commented Aug 8, 2017

liyinan926 commented Aug 8, 2017

liyinan926 commented Aug 9, 2017

kow3ns commented Aug 9, 2017

kow3ns commented Aug 9, 2017

liyinan926 commented Aug 9, 2017

thockin commented Aug 10, 2017

k8s-github-robot commented Aug 10, 2017

k8s-github-robot commented Aug 11, 2017

k8s-github-robot commented Aug 11, 2017

caesarxuchao commented Aug 22, 2017

liyinan926 commented Aug 22, 2017

liyinan926 commented Aug 1, 2017 •

edited

Loading

liyinan926 Aug 7, 2017 •

edited

Loading