Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Docker's health check until we officially support it #50796

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Disable Docker's health check until we officially support it #50796

merged 1 commit into from
Aug 17, 2017

Conversation

yguo0905
Copy link
Contributor

@yguo0905 yguo0905 commented Aug 16, 2017 •
edited

Ref: #50703

Tested locally.

Without this PR:

CONTAINER ID        IMAGE                                                  COMMAND                  CREATED             STATUS                     PORTS               NAMES
afdd796ddddc        gcr.io/ygg-gke-dev/nginx-healthcheck                   "nginx -g 'daemon ..."   5 minutes ago       Up 5 minutes (healthy)                       k8s_test-container_test-pod_default_8a1ad225-82bf-11e7-becb-480fcf514648_0

With this PR:

e3fb2437555f        gcr.io/ygg-gke-dev/nginx-healthcheck                   "nginx -g 'daemon ..."   10 seconds ago      Up 9 seconds                            k8s_test-container_test-pod_default_de82e83c-82c0-11e7-b3fc-480fcf514648_0

Release note:

Disable Docker's health check until we officially support it.

/assign @yujuhong
/assign @dchen1107

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2017
dchen1107
dchen1107 reviewed Aug 16, 2017
View reviewed changes
pkg/kubelet/dockershim/docker_container.go Outdated
@@ -131,6 +131,10 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi
OpenStdin: config.Stdin,
StdinOnce: config.StdinOnce,
Tty: config.Tty,
// Disable Docker's health check until we officially support it.
Healthcheck: &dockercontainer.HealthConfig{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this compatible with docker 1.10 and 1.11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the compatibility between new docker client API and old docker daemon, which should not be an issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But on the other hand, to cherry-pick this into 1.7 and 1.6, we need #48308..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the docker-related code changed a lot in the past 3 releases. Updating the docker client for each release will be a completely different PR....
I think it might be too intrusive. Let's think it through first...

yujuhong
yujuhong reviewed Aug 16, 2017
View reviewed changes
pkg/kubelet/dockershim/docker_container.go Outdated
@@ -131,6 +131,10 @@ func (ds *dockerService) CreateContainer(podSandboxID string, config *runtimeapi
OpenStdin: config.Stdin,
StdinOnce: config.StdinOnce,
Tty: config.Tty,
// Disable Docker's health check until we officially support it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the issue number in the comment #25829

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added a link.

@yujuhong
Copy link
Contributor

/retest
/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2017
@yujuhong
Copy link
Contributor

LGTM, but leaving @dchen1107 a chance to object

/retest

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yguo0905, yujuhong

Associated issue: 50703

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50563, 50698, 50796)

@k8s-github-robot k8s-github-robot merged commit e86f43b into kubernetes:master Aug 17, 2017
@yujuhong yujuhong mentioned this pull request Sep 1, 2017
Closed
asacbp
asacbp reviewed Dec 11, 2017
View reviewed changes
pkg/kubelet/dockershim/docker_container.go
// (https://github.com/kubernetes/kubernetes/issues/25829).
Healthcheck: &dockercontainer.HealthConfig{
Test: []string{"NONE"},
},
Copy link

@asacbp asacbp Dec 11, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, this causes lots of warnings in docker log like:

Dec 11 08:50:29 HOSTNAME dockerd[14450]: time="2017-12-11T08:50:29.993217562+01:00" level=warning msg="Unknown healthcheck type 'NONE' (expected 'CMD') in container XXXXX"

is this really the cleanest way to tell docker to not use the healthcheck?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asacbp - that's what they are recommending, https://github.com/docker/engine-api/blob/master/types/container/config.go#L16 So maybe worth asking on the docker github issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has just been fixed in docker, but hasn't been included in any release yet.
moby/moby#35533

@yosifkit yosifkit mentioned this pull request Oct 3, 2018
Closed
@wglambert wglambert mentioned this pull request Oct 23, 2018
Closed
@heqg heqg mentioned this pull request Jan 28, 2021
Closed
@heqg heqg mentioned this pull request Mar 4, 2021
Closed
@CharlieC3 CharlieC3 mentioned this pull request Aug 17, 2021
Closed
@fernandesGabriel fernandesGabriel mentioned this pull request Jan 12, 2022
Merged
3 tasks
@shaunco shaunco mentioned this pull request Nov 6, 2023
Closed
@rephus rephus mentioned this pull request Jan 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@dchen1107 dchen1107 dchen1107 left review comments

@yujuhong yujuhong yujuhong left review comments

@asacbp asacbp asacbp left review comments

Assignees

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yguo0905 @yujuhong @dchen1107 @k8s-github-robot @dims @asacbp @k8s-ci-robot