-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set flexvolumeplugin.host so that it's not nil #51342
Conversation
sample failure: Sorry my comments are spread all over the place... |
/lgtm (good catch) |
/assign @TerraTech |
@wongma7: GitHub didn't allow me to assign the following users: TerraTech. Note that only kubernetes members can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@saad-ali please approve this, it fixes nil pointer exception at mount/attach time for all flexvolume plugins |
/sig storage |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TerraTech, jsafrane, wongma7 Associated issue: 51123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Automatic merge from submit-queue (batch tested with PRs 15994, 16182, 16190, 16174) UPSTREAM: 50843: FlexVolume: Add ability to control 'SupportsSELinux' during driver's init phase also includes kubernetes/kubernetes#51342
@TerraTech @MikaelCluseau @chakri-nelluri @verult
I assume this line was removed inadvertently, without plugin.host set the flexvolume silently fails at Mount/Attach* time. #50843
#51123
Please review, thanks!