Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

populate object name for admission attributes when CREATE #53185

Merged
merged 5 commits into from
Aug 22, 2019
Merged

populate object name for admission attributes when CREATE #53185

merged 5 commits into from
Aug 22, 2019

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Sep 28, 2017 •
edited
Loading

What this PR does / why we need it:
The admission attributes given to admission plugins do not populate object name on create.

Since the object is available, the name in the admission attributes should be populated if available.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #46107

Special notes for your reviewer:

Release note:

populate object name for admission attributes when CREATE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 28, 2017
@tallclair tallclair mentioned this pull request Oct 2, 2017
Closed
@tallclair tallclair assigned tallclair and unassigned timstclair Oct 2, 2017
@tallclair
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 3, 2017

/retest

@tallclair
Copy link
Member

tallclair commented Oct 17, 2017 •
edited
Loading

Looks reasonable to me.

EDIT: didn't mean to close.

@tallclair tallclair closed this Oct 17, 2017
@tallclair tallclair reopened this Oct 17, 2017
@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch 2 times, most recently from 52e5c1d to f2e6f91 Compare October 18, 2017 03:16
@dixudx
Copy link
Member Author

dixudx commented Oct 18, 2017

@liggitt @tallclair Updated. PTAL. Thanks.

@deads2k
Copy link
Contributor

deads2k commented Oct 18, 2017

@deads2k I know you had thoughts about ordering of admission relative to generated name, which this does not address

Yeah, I think we want to generate names ahead of admission.

@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from f2e6f91 to aae09ee Compare October 19, 2017 14:31
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2017
@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from aae09ee to 4bb65c3 Compare October 19, 2017 14:43
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 19, 2017

@liggitt @tallclair Updated. PTAL. Thanks.

@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from 4bb65c3 to 56ec515 Compare October 21, 2017 06:18
@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from d4615db to b9fa3eb Compare August 13, 2019 15:51
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 13, 2019 •
edited
Loading

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws a13ce8b3252e8d755fbce8c61c405dc2283b2023 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from b9fa3eb to 10e6a91 Compare August 14, 2019 09:09
@dixudx
Copy link
Member Author

dixudx commented Aug 19, 2019

@liggitt Please take a review. Thanks.

@liggitt
Copy link
Member

liggitt commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@liggitt liggitt moved this from Not required for GA to Required for GA, in progress in Admission Webhooks Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@liggitt
Copy link
Member

liggitt commented Aug 21, 2019

/priority important-soon
/kind feature

needs rebase

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 21, 2019
@dixudx dixudx force-pushed the fix_admission_attributes_populate_name branch from 10e6a91 to 2771503 Compare August 22, 2019 03:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@dixudx
Copy link
Member Author

dixudx commented Aug 22, 2019

@liggitt Rebased. PTAL. Thanks.

@liggitt
Copy link
Member

liggitt commented Aug 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 315dcca into kubernetes:master Aug 22, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 22, 2019
@dixudx dixudx deleted the fix_admission_attributes_populate_name branch August 23, 2019 02:54
@wking wking mentioned this pull request Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k deads2k left review comments

@tallclair tallclair tallclair left review comments

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/admission-control area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Admission Webhooks
Complete
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Admission does not populate object name on create
8 participants
@dixudx @tallclair @deads2k @fejta-bot @k8s-ci-robot @liggitt @timstclair @k8s-github-robot